Skip to content

Return an error when hide or unhide reports a failed status - #2401

Merged
pbiering merged 5 commits into
Kozea:masterfrom
oliviasculley:fix-sharing-toggle-error-status
Nov 20, 2026
Merged

pbiering merged 5 commits into
Kozea:masterfrom
oliviasculley:fix-sharing-toggle-error-status

Conversation

@oliviasculley

Copy link
Copy Markdown
Contributor

Update and delete already return HTTP 400 for status error. Hide, unhide, enable, and disable now do the same.

AI support

  • Model: Grok 4.7
  • Effort: autonomous agent session.
  • Generated parts: the status else branch, the changelog bullet, and radicale/tests/test_sharing_toggle_error.py.
  • Verified: flake8 and isort. pytest of that file (1 passed) on Python 3.14. The full tox -m all set was not passed in this environment: sudo cannot loop-mount.

Update and delete already return HTTP 400 for status "error".
Hide, unhide, enable, and disable now do the same.

Assisted-by: Grok 4.7 <noreply@x.ai>
@pbiering pbiering added under analysis sharing collection sharing labels Nov 19, 2026
Assisted-by: Grok 4.7 <noreply@x.ai>

@pbiering pbiering left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@pbiering pbiering added this to the 3.9.3 milestone Nov 19, 2026
@pbiering pbiering added the DRAFT PR in DRAFT status label Nov 19, 2026
@oliviasculley
oliviasculley marked this pull request as ready for review November 20, 2026 00:07
@pbiering pbiering removed the DRAFT PR in DRAFT status label Nov 20, 2026
@pbiering
pbiering merged commit d575850 into Kozea:master Nov 20, 2026
3 of 4 checks passed
@oliviasculley
oliviasculley deleted the fix-sharing-toggle-error-status branch November 20, 2026 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement sharing collection sharing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants