Skip to content

fix: Added check for conversion mode#300

Merged
shivaygupta-dotcom merged 1 commit into
mainfrom
fix/openapi2mcp-conversion-only-fields
Jul 17, 2026
Merged

fix: Added check for conversion mode#300
shivaygupta-dotcom merged 1 commit into
mainfrom
fix/openapi2mcp-conversion-only-fields

Conversation

@shivaygupta-dotcom

@shivaygupta-dotcom shivaygupta-dotcom commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

We were copying acl_attribute_type and access_token_claim_field from the spec into the plugin config regardless of mode, but Kong Gateway only allows those fields in conversion-listener mode — in conversion mode it hard-rejects them.

Added check to add these fields only in conversion-listener mod.

FTI: https://konghq.atlassian.net/browse/FTI-7733
GH: Kong/deck#2142

@shivaygupta-dotcom
shivaygupta-dotcom force-pushed the fix/openapi2mcp-conversion-only-fields branch from bc81074 to 45b4c00 Compare July 10, 2026 07:47
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.70%. Comparing base (7dc971f) to head (45b4c00).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #300   +/-   ##
=======================================
  Coverage   65.70%   65.70%           
=======================================
  Files          25       25           
  Lines        3260     3260           
=======================================
  Hits         2142     2142           
  Misses        905      905           
  Partials      213      213           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread openapi2mcp/oas3_testfiles/09-security-acl-conversion-mode.yaml
@shivaygupta-dotcom
shivaygupta-dotcom removed the request for review from Prashansa-K July 17, 2026 08:08
@shivaygupta-dotcom
shivaygupta-dotcom merged commit f8d0d2b into main Jul 17, 2026
5 checks passed
@shivaygupta-dotcom
shivaygupta-dotcom deleted the fix/openapi2mcp-conversion-only-fields branch July 17, 2026 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants