Prevent assertion from always failing - #1
Open
scfarley wants to merge 2 commits into
Open
Conversation
Casting SIZE_MAX to off_t results in -1, causing the assertion to always fail. Change the assertion to verify that clip, cast to size_t, does not exceed the data size of the buffer.
Cast values to unsigned types to safely compare sizes and offsets without truncation.
Author
|
After fixing the assert, I noticed that syncing some large files had become excruciatingly slow. The second commit fixes that issue. |
dsh2dsh
added a commit
to dsh2dsh/freebsd-ports
that referenced
this pull request
Jun 23, 2026
|
Thanks! It fixed my problem. |
Author
You are welcome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Casting SIZE_MAX to off_t results in -1, causing the assertion to always
fail. Change the assertion to verify that clip, cast to size_t, does
not exceed the data size of the buffer.