Open
Conversation
- replace the shared mapper sampler with per textureview samplers - keep image interpolation driven by ImageProperty settings - use linear sampling for color and opacity LUT textures - use nearest sampling for label outline lookup textures
33 tasks
daker
force-pushed
the
webgpu-imagemapper
branch
from
29c8022 to
b933f22
Compare
Collaborator
|
Should we just impliment ImageResliceMapper and then wrap it for ImageMapper? |
Collaborator
Author
|
@PaulHax vtkWebGPUImageMapper is for axis aligned image slicing while vtkWebGPUImageResliceMapper is for arbitrary plane/polydata slicing, custom geometry, slab logic so I was more thinking |
Collaborator
|
Axis aligned image slicing is a subset of arbitrary plane/polydata slicing. But I'm putting the cart before the horse here, your right, getting WebGPU ImageMapper ironed out first is the way. C++ VTK peeps are working on WebGPU Image Mapper as well: https://gitlab.kitware.com/vtk/vtk/-/merge_requests/12851 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
feat(WebGPU): add coincident topology offsets to ImageMapper
feat(WebGPU): add dependent image modes for single component, LA, RGB…
feat(WebGPU): add independent component mixing to ImageMapper
feat(WebGPU): add zbuffer to ImageMapper
feat(WebGPU): add label outline to ImageMapper
feat(WebGPU): move ImageMapper off shared clampSampler
perf(WebGPU): reduce ImageMapper UBO array allocations
Results
Changes
PR and Code Checklist
npm run reformatto have correctly formatted codeTesting