feat(WebGPU): add clipping plane support for polydata, volume and image#3464
Open
daker wants to merge 1 commit intoKitware:masterfrom
Open
feat(WebGPU): add clipping plane support for polydata, volume and image#3464daker wants to merge 1 commit intoKitware:masterfrom
daker wants to merge 1 commit intoKitware:masterfrom
Conversation
daker
force-pushed
the
feat-cropplanes
branch
2 times, most recently
from
9095a4b to
fe8e279
Compare
Collaborator
Author
|
@sankhesh would you mind doing a quick code review? |
This was referenced Apr 7, 2026
finetjul
reviewed
Apr 7, 2026
Member
finetjul
left a comment
finetjul
left a comment
There was a problem hiding this comment.
Generally speaking, there are lots of duplication. Could you come up with a "helper" that gets injected into the mappers ?
Collaborator
Author
|
@finetjul thanks for the code review, i will try to improve the code. |
daker
force-pushed
the
feat-cropplanes
branch
2 times, most recently
from
5fd1cde to
c0f81bf
Compare
daker
changed the title
finetjul
reviewed
Apr 10, 2026
| model.renderable.getMTime() <= utime | ||
| model.renderable.getMTime() <= utime && | ||
| clippingPlanesMTime <= utime && | ||
| activeCamera.getMTime() <= utime |
Member
There was a problem hiding this comment.
Considering the camera mtime has a big impact on performance. It means each time the camera is moved the UBO must be rebuilt.
Can you restrain the conditions ?
Collaborator
Author
There was a problem hiding this comment.
do you think this would be sufficient?
const condition = !model.is2D && model.useRendererMatrix && model.renderable.getNumberOfClippingPlanes() > 0;
if (
...
(!condition || activeCamera.getMTime() <= utime)
)
Collaborator
Author
There was a problem hiding this comment.
i will try to see if i can make them camera independant
|
|
||
| if (!hit) | ||
| { | ||
| traverseVals[vNum] = vec4<f32>(0.0,0.0,0.0,0.0); |
daker
force-pushed
the
feat-cropplanes
branch
2 times, most recently
from
b342d93 to
cfabfc4
Compare
Implement WebGPU clipping planes in CellArrayMapper, VolumePassFSQ and ImageMapper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
fixes : #2061
fixes : #2293
Results
Implement WebGPU clipping planes for polydata, image and volume rendering,
Use VolumeRenderingWithPolyData example for testing.
Changes
PR and Code Checklist
npm run reformatto have correctly formatted codeTesting