Merged
Conversation
jourdain
reviewed
Apr 14, 2026
jourdain
reviewed
Apr 14, 2026
jourdain
reviewed
Apr 14, 2026
jourdain
reviewed
Apr 14, 2026
jourdain
reviewed
Apr 14, 2026
jourdain
reviewed
Apr 14, 2026
jourdain
reviewed
Apr 14, 2026
UlysseDurand
commented
Apr 14, 2026
Contributor
Author
UlysseDurand
left a comment
UlysseDurand
left a comment
There was a problem hiding this comment.
Some markdown problems persist, I will see later.
I fixed some examples thanks to your comments.
Also replace all mentions of commands like `[pvpython] [script.py] --venv [venv]` by `[pvpython] --venv [venv] [script.py]`
jourdain
reviewed
Apr 16, 2026
jourdain
reviewed
Apr 16, 2026
Collaborator
|
Getting closer, ok to merge after another pass based on my comments. |
UlysseDurand
added a commit
to UlysseDurand/trame
that referenced
this pull request
Apr 16, 2026
UlysseDurand
force-pushed
the
fix-examples2
branch
from
389c027 to
5679c70
Compare
…ve arg Ref: https://github.com/Kitware/trame/pull/876/changes/ BASE..b763491#r3090520084
Ref: https://github.com/Kitware/trame/pull/876/changes/ BASE..b763491#r3090494150
UlysseDurand
commented
Apr 16, 2026
Contributor
Author
UlysseDurand
left a comment
UlysseDurand
left a comment
There was a problem hiding this comment.
Comments should be now resolved
jourdain
reviewed
Apr 16, 2026
| @@ -1,4 +1,3 @@ | |||
| import paraview.web.venv # Available in PV 5.10 | |||
| from paraview import simple | |||
Collaborator
There was a problem hiding this comment.
Do you want to update it to a TrameApp and vue3?
jourdain
reviewed
Apr 16, 2026
|
|
||
| # ----------------------------------------------------------------------------- | ||
|
|
||
| server = get_server(client_type="vue3") |
jourdain
reviewed
Apr 16, 2026
| import paraview.web.venv # Available in PV 5.11 | ||
| from paraview import simple | ||
|
|
||
| from trame.app import get_server |
jourdain
reviewed
Apr 16, 2026
|
|
||
| from trame.app import get_server | ||
| from trame.ui.vuetify import SinglePageLayout | ||
| from trame.widgets import paraview, vuetify |
jourdain
reviewed
Apr 16, 2026
|
|
||
| from trame.app import get_server | ||
| from trame.ui.vuetify import SinglePageLayout | ||
| from trame.widgets import client, paraview, vuetify |
jourdain
reviewed
Apr 16, 2026
| from trame_server import Server | ||
| from trame_server.controller import Controller | ||
|
|
||
| from trame.app import get_server |
Collaborator
There was a problem hiding this comment.
TrameApp (class not decorator) and use v3 as name instead of vuetify.
jourdain
reviewed
Apr 16, 2026
| import paraview.web.venv # Available in PV 5.10-RC2+ | ||
| from paraview import simple | ||
|
|
||
| from trame.app import asynchronous, get_server |
jourdain
reviewed
Apr 16, 2026
| import paraview.web.venv | ||
| from paraview import simple | ||
|
|
||
| from trame.app import asynchronous, get_server |
jourdain
reviewed
Apr 16, 2026
| python3.9 -m venv .pvenv | ||
| python3.12 -m venv .pvenv | ||
| source .pvenv/bin/activate | ||
| pip install trame>=2.0.0 |
Collaborator
There was a problem hiding this comment.
update version of trame here...
Contributor
Author
There was a problem hiding this comment.
jourdain
reviewed
Apr 16, 2026
| # ----------------------------------------------------------------------------- | ||
| from paraview import simple | ||
|
|
||
| from trame.app import get_server |
jourdain
reviewed
Apr 16, 2026
| from trame.ui.router import RouterViewLayout | ||
| from trame.ui.vuetify3 import SinglePageWithDrawerLayout | ||
| from trame.widgets import plotly, router | ||
| from trame.widgets import vuetify3 as vuetify |
Collaborator
There was a problem hiding this comment.
If you can, use TrameApp too
Collaborator
|
If you want to get that merge, my comments coulld be tackled in another PR. I'm ok merging it as-is. |
Ref: https://github.com/Kitware/trame/pull/876/changes/ BASE..bd2d328#r3092867340
UlysseDurand
commented
Apr 16, 2026
Contributor
Author
UlysseDurand
left a comment
UlysseDurand
left a comment
There was a problem hiding this comment.
Yes I would like to make this PR and update all the examples with TrameApp in another PR, thank you.
| python3.9 -m venv .pvenv | ||
| python3.12 -m venv .pvenv | ||
| source .pvenv/bin/activate | ||
| pip install trame>=2.0.0 |
Contributor
Author
There was a problem hiding this comment.
jourdain
pushed a commit
that referenced
this pull request
Apr 16, 2026
jourdain
pushed a commit
that referenced
this pull request
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix examples that didn't work.
The remaining examples I didn't manage to run are the following:
examples/Applications/ZarrContourViewerexamples/validationfolderApart from these, all the examples and their features were tested.