Skip to content

add vince biography - #18

Merged
vschac merged 2 commits into
testingfrom
lgh-24-add-schackniess-bio
Oct 16, 2026
Merged

vschac merged 2 commits into
testingfrom
lgh-24-add-schackniess-bio

Conversation

@vschac

@vschac vschac commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

What changed

Added the bio that describes me

Linear issue

lgh-24

Author checklist

  • Exactly one new file, bios/firstname-lastname.yml, and nothing else
  • Filename is the slug of my name field ("Jane Doe" -> jane-doe.yml)
  • Previewed locally (docker compose up --build, or python -m generator serve)
  • CI is green (validate-bios, build-site)
  • Requested the reviewer named on my Linear issue
  • Base branch is testing

Reviewer

Check these four things, then Approve or Request changes:

  • Required keys present: name, team, headline, about; team is one
    of the teams listed in site.yml
  • Filename matches the author's name and ends in .yml
  • about reads professionally — a real sentence or two, no placeholder text
  • No files outside this author's own bio were touched

Be specific and kind, comment on the code and not the person, approve when it
is good enough to ship rather than perfect, and save Request changes for a
real blocker.

@vschac
vschac requested a review from eekansh-M October 16, 2026 18:41
@linear-code

linear-code Bot commented Oct 16, 2026

Copy link
Copy Markdown

LGH-24

@eekansh-M eekansh-M left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

He has a name, team, and about. He also went well beyond and did all the optional stuff

@vschac
vschac merged commit 0030ab3 into testing Oct 16, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants