Feature/preallocate large header - #83
Open
Siebje wants to merge 12 commits into
Open
Conversation
…ly re-saving the trace set
…ing metadata padding
rwols
requested changes
Aug 21, 2026
| // which is not been finalized in Java 21. | ||
| System.gc(); | ||
| try { | ||
| Thread.sleep(100); |
Collaborator
Author
There was a problem hiding this comment.
Have you considered reading the comments, the commit log, or the method name? The name of the method is 'awaitFileUnmapping'. System.gc() returns immediately, which will lead to the file handle being kept open until the GC is complete.
This will have less impact on very small trace sets, while still being plenty
Siebje
force-pushed
the
feature/preallocate-large-header
branch
from
August 21, 2026 13:35
143e368 to
39edc87
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows pre-allocating a header of fixed size, which allows a user to make modifications and additions to the global parameters without needing to completely rewrite the file (up to the preset limit). The initial reserved size was 1MB, but it was reduced to 256kB after some user feedback.