feat: parser implementation and structure refactor#11
Open
WojtussToKox wants to merge 8 commits into
Open
Conversation
WojtussToKox
changed the title
MichalSzandar
approved these changes
May 17, 2026
M1KUS3Q
reviewed
May 17, 2026
| std::cout << " [SceneObject] Utworzono obiekt: " << name << "\n"; | ||
| } | ||
|
|
||
| void setTransform(double posX, double posY, double width, double height, double rotation) { |
There was a problem hiding this comment.
This seems like it should be abstracted in the future, into either just math vectors or a custom better suited Transform type.
For scaffolding its good enough though i think
I would just make the user pass in the transform struct instead of this in-place construction
M1KUS3Q
reviewed
May 17, 2026
| double blink_frequency_hz = 1; | ||
| } | ||
|
|
||
| message ScriptComponent { |
There was a problem hiding this comment.
additional dictionary or something for script parameters? Or are we just expecting each Script passed to be void -> void ?
M1KUS3Q
reviewed
May 17, 2026
| return obj; | ||
| } | ||
|
|
||
| std::unique_ptr<Component> Parser::buildComponent(const NeuronIDE::Component& protoComp) { |
There was a problem hiding this comment.
Delegate this to the components themselves?
Adding a case here for each component seems wrong when we can just do inheritence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.