Repository navigation
Reject data entities shadowing generated GraphQL operation roots - #325
Open
theman6660 wants to merge 1 commit into
Open
theman6660 wants to merge 1 commit into
theman6660 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reserved-name check only examines entities that contribute operations. A data-only entity named Query or Mutation bypasses it, even when another entity causes a root of that name to be generated. The resulting SDL contains two same-named type definitions and introspection also becomes ambiguous.
Reject the collision when a corresponding operation root will actually be generated. Data-only names without such a root keep their existing behavior. Tests cover both GraphQLHandler and standalone SchemaBuilder, either entity declaration order, and unaffected schema controls.
Before the fix, 8 new collision cases failed and the normal-schema control passed. Added two more positive controls for names with no generated root. GraphQL and UseCase suites with all 11 new cases: 438 passed, 1 skipped. Ruff and git diff --check passed.
Prepared with OpenAI Codex assistance. No production usage, human review or upstream CI is claimed.