Repository navigation
Retain one-shot entity iterables during grouped operation scans - #324
Open
theman6660 wants to merge 1 commit into
Open
theman6660 wants to merge 1 commit into
theman6660 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scan_grouped_methods accepts an Iterable but iterates it twice. The first pass collects entity type names and consumes iterators/generators, leaving the second pass with no entities. This silently returns an empty operation map and bypasses all collision and reserved-name checks.
Materialize the entity iterable once before the two passes. Tests exercise both query and mutation extraction with the real SchemaBuilder, list/tuple controls, iterator/generator inputs, group-name collisions, and reserved names.
Before the fix, 8 new cases failed and 4 controls passed; all 12 now pass. GraphQL and UseCase suites: 439 passed, 1 skipped. Ruff and git diff --check passed. This addresses the helper's declared iterable contract; no claim is made that built-in list-based handler callers previously triggered the issue.
Prepared with OpenAI Codex assistance. No production usage, human review or upstream CI is claimed.