Implement bethemean energy loss option. Enable optional per-material …#222
Open
RobMina wants to merge 1 commit into
Open
Implement bethemean energy loss option. Enable optional per-material …#222RobMina wants to merge 1 commit into
RobMina wants to merge 1 commit into
Conversation
…energy loss configuration (defaults to the global config setting).
brownd1978
approved these changes
Jul 14, 2026
brownd1978
left a comment
brownd1978
left a comment
Contributor
There was a problem hiding this comment.
Thanks Rob this looks great! I just have 1 quibble about an error printout.
| } else if (key == "bethemean") { | ||
| matObj->setElossMode(2); | ||
| } else { | ||
| ErrMsg(warning) << "MatMaterialList: unrecognized trailing token '" << token |
Contributor
There was a problem hiding this comment.
I suggest to throw here instead. ErrMsg is a deprecated legacy class (I'll add an issue).
Contributor
|
Rob, could you please paste in the output from MatEnv_unit? It gets suppressed in the automatic tests, but in this case it would be good to have this as part of the record. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…energy loss configuration (defaults to the global config setting).
For issue #221