Open
Conversation
|
Awesome. I’ll pull it into the next release.
Thanks,
Phil
… On May 12, 2019, at 3:56 AM, Li-Wen Hsu ***@***.***> wrote:
You can view, comment on, or merge this pull request online at:
#66 <#66>
Commit Summary
Add Cirrus-CI config
File Changes
A .cirrus.yml <https://github.com/Juniper/libxo/pull/66/files#diff-0> (14)
Patch Links:
https://github.com/Juniper/libxo/pull/66.patch <https://github.com/Juniper/libxo/pull/66.patch>
https://github.com/Juniper/libxo/pull/66.diff <https://github.com/Juniper/libxo/pull/66.diff>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#66>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAROIOGNMCDQTML4G2CFZCLPU7EUJANCNFSM4HMJZZSA>.
|
Author
|
Thanks, it would be nice if we can remove the GNU-make only syntax in |
|
On May 12, 2019, at 9:22 PM, Li-Wen Hsu ***@***.***> wrote:
Thanks, it would be nice if we can remove the GNU-make only syntax in warnings.mk to drop gmake dependency.
Unfortunately, gmake is the outcome of choosing to use autoconf, which helps make the code run in various environments. I have distinct Makefiles for building the library as part of FreeBSD’s “make world".
Thanks,
Phil
|
|
Worth revisiting this now? |
ac72f5b to
36d084e
Compare
Author
|
The Cirrus-CI config has been update but there are some error/warnings from the compiler, should we fix those first? https://github.com/lwhsu/libxo/runs/14633783929 |
I'd say so. I guess we turned off the warning in FreeBSD? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.