Repository navigation
Convert range views of a sparse vector from their stored entries - #1134
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1134 +/- ##
=======================================
Coverage 94.68% 94.69%
=======================================
Files 16 16
Lines 10433 10434 +1
=======================================
+ Hits 9879 9880 +1
Misses 554 554 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
30 tasks done
ViralBShah
added a commit
that referenced
this pull request
Oct 27, 2026
Backports of the merged PRs labelled `backport 1.14`, cherry-picked with `-x` in the order they were merged on `main`. `release-1.14` starts at b0aa455 (#1104), the commit JuliaLang/julia's `release-1.14` pins, and every PR merged on `main` since then is labelled, so this branch's tree is identical to `main`'s at 9bfad27. - [x] #1105 - [x] #1011 - [x] #1107 - [x] #1108 - [x] #1110 - [x] #1111 - [x] #1114 - [x] #1112 - [x] #1115 - [x] #1117 - [x] #1118 - [x] #1109 - [x] #1113 - [x] #1122 - [x] #1123 - [x] #1120 - [x] #1124 - [x] #1125 - [x] #1116 - [x] #1121 - [x] #1126 - [x] #1128 - [x] #1130 - [x] #1131 - [x] #1119 - [x] #1133 - [x] #1127 - [x] #1135 - [x] #1134 - [x] #1137 #1137 removes the first-call compile time that #1128 added, which the TTFX check flagged on this PR. #1132 merged into the branch of #1131 and is part of its commit. Not bug fixes: #1011 adds a deprecation, #1109 changes the `sprand` value stream for a value function, #1113 changes the result shape of `SparseMatrixCSC` of a vector view, and #1119, #1133, #1134 and #1135 add methods for views. They are included because they are labelled and 1.14 is not released yet. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Viral B. Shah <ViralBShah@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A range view of a sparse vector,
view(x, 2:6), is converted to aSparseVectorby reading it as a dense vector, soSparseVector,sparse,sparsevec,convertand sparsevcat,hcatandhvcattake O(n), drop stored zeros and giveIntindices, andkronof a range view is dense.Before
After
For
w = view(sparsevec([1, n], [1.0, 2.0], n), 1:n)withn = 10^7andy = sparsevec([1], [1.0], 2), the minimum of three runs and the@allocatedof a warm call:f(w)SparseVector(w)vcat(w, w)kron(w, y)The
SparseVectorcopy constructors andsparsevec, which #1119 widened to whole views, also takeSparseVectorPartialView, whosenonzeroindsandnonzerosgive its stored entries relative to the range.convertand the concatenations reach them through_makesparse.krontakes range views in_SparseKronGroupand in its vector methods, so they go through the same conversion. The_sparsevectorhelper that sparsemapuses for views now callsSparseVectorinstead of repeating it.This touches dispatch.
Potential breakage: for a range view, these conversions and concatenations keep its stored zeros and the parent's index type, and
kronof one is sparse rather than dense, as forx[2:6].Products with a range view are in #1135.
🤖 Generated with Claude Code