Repository navigation
Catch only the factorization's SingularException in sparse cond - #1132
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## vs/cond-result-type #1132 +/- ##
=======================================================
- Coverage 94.70% 94.68% -0.02%
=======================================================
Files 16 16
Lines 10424 10432 +8
=======================================================
+ Hits 9872 9878 +6
- Misses 552 554 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
30 tasks done
ViralBShah
added a commit
that referenced
this pull request
Oct 27, 2026
Backports of the merged PRs labelled `backport 1.14`, cherry-picked with `-x` in the order they were merged on `main`. `release-1.14` starts at b0aa455 (#1104), the commit JuliaLang/julia's `release-1.14` pins, and every PR merged on `main` since then is labelled, so this branch's tree is identical to `main`'s at 9bfad27. - [x] #1105 - [x] #1011 - [x] #1107 - [x] #1108 - [x] #1110 - [x] #1111 - [x] #1114 - [x] #1112 - [x] #1115 - [x] #1117 - [x] #1118 - [x] #1109 - [x] #1113 - [x] #1122 - [x] #1123 - [x] #1120 - [x] #1124 - [x] #1125 - [x] #1116 - [x] #1121 - [x] #1126 - [x] #1128 - [x] #1130 - [x] #1131 - [x] #1119 - [x] #1133 - [x] #1127 - [x] #1135 - [x] #1134 - [x] #1137 #1137 removes the first-call compile time that #1128 added, which the TTFX check flagged on this PR. #1132 merged into the branch of #1131 and is part of its commit. Not bug fixes: #1011 adds a deprecation, #1109 changes the `sprand` value stream for a value function, #1113 changes the result shape of `SparseMatrixCSC` of a vector view, and #1119, #1133, #1134 and #1135 add methods for views. They are included because they are labelled and 1.14 is not released yet. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Viral B. Shah <ViralBShah@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1131.
Since #1126 sparse
condwraps the wholeopnormestinvestimator in atry, so aSingularExceptionfrom anywhere inside it becomesInf, and a singular triangular or diagonal matrix is only found once the estimator has allocated its blocks and run its first solve. Raised in the post-merge review of #1126.Before (#1131),
cond(A, 1)of a singularAwithn = 10^6and one zero on the diagonalAAfter
ABoth return
Inf, before and after.factorizethrows aSingularExceptionfor a singular LU, and for a singular Hermitian matrix once Cholesky and LDLt have failed and it falls back to the LU (#1116); only the triangular and diagonal factors it returns leave the zero pivot to the solve. Socondnow catches aroundfactorizealone and checks the diagonal of those factors with_issingularfactor, which reuses the triangular solve's_trisingular, before it calls the estimator;opnormestinv(A, t)keeps its behaviour and calls the new_opnormestinv(A, F, t)with the factorization. A sweep ofcondagainst dense overInt,Float32,Float64,ComplexF32,ComplexF64,Rational{Int},BigFloatandComplex{BigFloat}, on general, singular, triangular, diagonal and Hermitian matrices, gives the same results as #1131 with a seeded RNG.Written by Claude Code.
🤖 Generated with Claude Code