Skip to content

Return the same float type from sparse cond for singular and nonsingular matrices - #1131

Merged
ViralBShah merged 2 commits into
mainfrom
vs/cond-result-type
Oct 27, 2026
Merged

ViralBShah merged 2 commits into
mainfrom
vs/cond-result-type

Catch only the factorization's `SingularException` in sparse `cond` (…

ae3041d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 27, 2026 in 0s

94.68% (-0.02%) compared to 2bef1fd

View this Pull Request on Codecov

94.68% (-0.02%) compared to 2bef1fd

Details

Codecov Report

❌ Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.68%. Comparing base (2bef1fd) to head (ae3041d).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/linalg.jl 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1131      +/-   ##
==========================================
- Coverage   94.70%   94.68%   -0.02%     
==========================================
  Files          16       16              
  Lines       10423    10432       +9     
==========================================
+ Hits         9871     9878       +7     
- Misses        552      554       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.