Repository navigation
Solve a real UmfpackLU against a ComplexF32 vector in ldiv! - #1112
Merged
Merged
Conversation
ViralBShah
enabled auto-merge (squash)
October 26, 2026 13:30
The complex-vector kernel built its real-part buffer with `real.(b)`, which is `Float32` for a `ComplexF32` right-hand side, and UMFPACK has no `Float32` solve. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ViralBShah
force-pushed
the
vs/umfpack-complex-rhs-eltype
branch
from
October 26, 2026 13:32
63054c1 to
1fcdf3b
Compare
ViralBShah
disabled auto-merge
October 26, 2026 13:56
ViralBShah
enabled auto-merge (squash)
October 26, 2026 13:56
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1112 +/- ##
=======================================
Coverage 94.72% 94.72%
=======================================
Files 16 16
Lines 10310 10315 +5
=======================================
+ Hits 9766 9771 +5
Misses 544 544 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ldiv!of a realUmfpackLUwith aComplexF32vector throws aMethodError; the matrix case and\work.Before
After
The vector kernel for a complex right-hand side and a real factor solves the real and imaginary parts separately, through a scratch buffer it built with
c = real.(b). That buffer has the real eltype ofb,Float32here, and UMFPACK only solves inFloat64. It is now allocated asFloat64and filled in place, as the matrix kernel already does. The 3-argument form andtranspose(F)andF'go through the same kernel.🤖 Generated with Claude Code