Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #575 +/- ##
=======================================
Coverage 94.86% 94.87%
=======================================
Files 14 14
Lines 3000 3004 +4
=======================================
+ Hits 2846 2850 +4
Misses 154 154
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
I'm not sure why that test failed, seems like a run fail rather than code related to me. |
Member
|
Member
|
I opened #576 |
Contributor
Author
|
Looks like that was merged could you retrigger the tests on this PR? Pretty sure they're good. |
Contributor
Author
|
Cheers. Happy for this to be reviewed as a candidate to be merged. It only touches the complex bigfloat gamma that I added earlier this year so it shouldn't step on anyone's toes. :) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves the accuracy and performance of the Complex{BigFloat} variant of loggamma that I added earlier this year in line with improvements I recently made over in Gamma.jl. The relevant PR there contains some more info: JuliaMath/Gamma.jl#23
In brief, roughly 6% of bits of precision were lost with the current implementation at very high precisions and along with fixing that the performance also got an upgrade:
loggamma(::Complex{BigFloat}), z ∈ {0.625+0.375i, −2.75+1.5i, 3+40i, 0.5+300i}