Skip to content

Implement loggamma#4

Merged
oscardssmith merged 10 commits intoJuliaMath:mainfrom
TSGut:main
Apr 8, 2026
Merged

Implement loggamma#4
oscardssmith merged 10 commits intoJuliaMath:mainfrom
TSGut:main

Conversation

@TSGut
Copy link
Copy Markdown
Collaborator

@TSGut TSGut commented Apr 7, 2026

Moving progress over from JuliaMath/Bessels.jl#128

I also changed the name of the gamma.jl file to core.jl, happy for it to be renamed but gamma.jl and Gamma.jl causes namespace issues on some operating systems and we need Gamma.jl for the module. I will maybe do a few more commits to tidy this up, then it should be ready

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (a6ae907) to head (3c1b159).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main        #4      +/-   ##
===========================================
+ Coverage   98.76%   100.00%   +1.23%     
===========================================
  Files           2         3       +1     
  Lines          81       281     +200     
===========================================
+ Hits           80       281     +201     
+ Misses          1         0       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TSGut
Copy link
Copy Markdown
Collaborator Author

TSGut commented Apr 7, 2026

@oscardssmith Ready for review.

@oscardssmith
Copy link
Copy Markdown
Member

I'd like a different name than core. Maybe gamma_implimentation.jl?

@TSGut
Copy link
Copy Markdown
Collaborator Author

TSGut commented Apr 8, 2026

File renamed. 😄

@oscardssmith
Copy link
Copy Markdown
Member

Thanks! Would be nice to have optimized lower precision versions, but this seems pretty good to start. If you don't object, I'll kick off the registration tonight/tomorrow.

@oscardssmith oscardssmith merged commit 541fa23 into JuliaMath:main Apr 8, 2026
6 checks passed
@TSGut
Copy link
Copy Markdown
Collaborator Author

TSGut commented Apr 8, 2026

Happy for that to go ahead since I want to move my own work to use this instead soon.

I am also happy to revisit lower precision versions once that's done, I think it would just require looking into the right approximations to hard code in, similar to the current stuff.

@oscardssmith
Copy link
Copy Markdown
Member

generally the low precision ones are easier since at the least, you can generally just cut a couple degrees off of the polynomial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants