Repository navigation
Bind AMF_VIDEO_CONVERTER_COLOR_PROFILE_ENUM as an Int32 enum - #475
Merged
Merged
Conversation
Fixes JuliaIO#474. The FFmpeg 9 bindings declared the return type of av_amf_get_color_profile as an empty placeholder struct, because the enum lives in AMD's AMF SDK headers, which are not available when generating. A ccall returning an empty mutable struct makes Julia's code generation crash or loop forever (JuliaLang/julia#64383), so for example a juliac build that depends on VideoIO never finishes. Handle it like AMF_SURFACE_FORMAT: add it to printer_blacklist and define it in the prologue as Int32, with its values from the AMF SDK's components/ColorSpace.h. The bindings are regenerated with Julia 1.11, against FFMPEG_jll 9.0.1 and 8.1.2 as before, keeping the existing artifact paths in the names of anonymous unions. Add a regression test that the function returns Int32 and compiles. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #475 +/- ##
==========================================
- Coverage 84.93% 84.89% -0.04%
==========================================
Files 13 13
Lines 2077 2092 +15
==========================================
+ Hits 1764 1776 +12
- Misses 313 316 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
v1.10.1 release. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #474. The FFmpeg 9 bindings declared the return type of av_amf_get_color_profile as an empty placeholder struct, because the enum lives in AMD's AMF SDK headers, which are not available when generating. A ccall returning an empty mutable struct makes Julia's code generation crash or loop forever (JuliaLang/julia#64383), so for example a juliac build that depends on VideoIO never finishes.
Handle it like AMF_SURFACE_FORMAT: add it to printer_blacklist and define it in the prologue as Int32, with its values from the AMF SDK's components/ColorSpace.h. The bindings are regenerated with Julia 1.11, against FFMPEG_jll 9.0.1 and 8.1.2 as before, keeping the existing artifact paths in the names of anonymous unions.
Add a regression test that the function returns Int32 and compiles.