Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #733
Problem
add_nodesandadd_edgescould increasenum_nodeswithout extendinggraph_indicator, leaving batched graphs inconsistent and causing downstream operations to misbehave or fail.Solution
Reject node growth on batched graphs until the API defines which component graph should own new nodes. Preserve unbatched behavior and extend an explicit indicator for single-graph inputs.
Changes
add_nodesandadd_edges.Testing
Pkg.test("GNNGraphs"; coverage=false): 1,391 passed, 8 broken, 1,399 total; the test runner reported success.git diff --check: passed.