Skip to content

fixes broken example for "weighted mean of more than two colors" - #571

Draft
alex-s-gardner wants to merge 1 commit into
JuliaGraphics:masterfrom
alex-s-gardner:weighted_color_mean_docs
Draft

alex-s-gardner wants to merge 1 commit into
JuliaGraphics:masterfrom
alex-s-gardner:weighted_color_mean_docs

Conversation

@alex-s-gardner

Copy link
Copy Markdown

old example no longer works

@codecov

codecov Bot commented Jul 3, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.75%. Comparing base (3e362e3) to head (a251ec1).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #571   +/-   ##
=======================================
  Coverage   96.75%   96.75%           
=======================================
  Files           9        9           
  Lines        1296     1296           
=======================================
  Hits         1254     1254           
  Misses         42       42           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kimikage
kimikage marked this pull request as draft September 20, 2026 12:15
@kimikage

Copy link
Copy Markdown
Collaborator

When was it deprecated in the first place?
Since I'm now away from Colors.jl, I don't know where that discussion took place.

@alex-s-gardner

Copy link
Copy Markdown
Author

I'm not sure deprecated is the right description. Changing title to fixes "broken" example

@alex-s-gardner alex-s-gardner changed the title fixes depricated example for "weighted mean of more than two colors" fixes broken example for "weighted mean of more than two colors" Sep 21, 2026
@kimikage

kimikage commented Sep 21, 2026

Copy link
Copy Markdown
Collaborator

How did you determine that it was broken?
The document generation passes even without this PR.

And if there is no consensus on the deprecation, we should consider whether we can fix the implementation before updating the documentation.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants