Repository navigation
Fix @grad for qualified function names - #330
Closed
gezerui888 wants to merge 1 commit into
Closed
gezerui888 wants to merge 1 commit into
gezerui888 wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #330 +/- ##
=======================================
Coverage 94.32% 94.32%
=======================================
Files 19 19
Lines 1710 1710
=======================================
Hits 1613 1613
Misses 97 97 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Nov 7, 2026
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #318.
Qualified definitions such as
@grad function M.f(x)fail withgensym(::Expr). I changed the generated closure name to use a symbol prefix, while preserving the qualified callee for dispatch and tape recording.The regression checks qualified and unqualified rules through direct gradients and ordinary/compiled tape replay, including primal values after inputs change.
Validation:
cc @devmotion