Repository navigation
Move examples into doctests and fix the in-place Jacobian example - #304
Merged
Merged
Conversation
#114) #128 ported `A_mul_Bc!(out, A, B)` (= `A * B'`) to `mul!(out, a + b, a * b)`, dropping the adjoint, so `g!` no longer matched `f`. The examples are now doctests in the Gradients and Jacobians sections of the API docs, so CI checks them, and `examples/` is removed. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #304 +/- ##
=======================================
Coverage 88.21% 88.21%
=======================================
Files 19 19
Lines 1934 1934
=======================================
Hits 1706 1706
Misses 228 228 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #114. #128 attempted to fix it by porting
A_mul_Bc!(out, A, B)(=A * B') tomul!(out, a + b, a * b), which drops the adjoint. Since then,g!inexamples/jacobian.jlhas not matchedf, and nothing checked it.This PR:
examples/gradient.jlandexamples/jacobian.jlinto doctested examples in the Gradients and Jacobians sections of the API docs, with the adjoint restored (g!(out, a, b) = mul!(out, a + b, (a * b)')), and removesexamples/fand∇f!inline in the README benchmark instead ofinclude(joinpath(Pkg.dir("ReverseDiff"), "examples/gradient.jl"))🤖 Generated with Claude Code