Repository navigation
fix: restore Diffractor support on Julia 1.10 and 1.11 - #1079
Closed
gdalle-bot wants to merge 1 commit into
Closed
gdalle-bot wants to merge 1 commit into
gdalle-bot wants to merge 1 commit into
Conversation
Work around the broadcasting bug of Diffractor v0.2.7 to v0.2.10 (JuliaDiff/Diffractor.jl#290) by defining the missing `FwdMap{E}` constructor in the extension. Bump the compat bound to v0.2.10 and reactivate the Diffractor test group. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017t9zghYPb67WRAZPDhMCNt
gdalle-bot
force-pushed
the
fix/diffractor
branch
from
October 12, 2026 09:45
c7c3499 to
11bf04e
Compare
Member
|
Okay this is actually useless, nevermind |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1079 +/- ##
===========================================
+ Coverage 60.79% 93.92% +33.13%
===========================================
Files 137 141 +4
Lines 8111 8197 +86
===========================================
+ Hits 4931 7699 +2768
+ Misses 3180 498 -2682
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
This PR was generated by a coding agent, please disregard it until @gdalle has reviewed it.
Restore
AutoDiffractorsupport, which has been frozen at Diffractor v0.2.6 and untested in CI.Diagnosis
Two independent problems:
src/stage1/broadcast.jlcallsFwdMap{E}(f), but the only constructor isFwdMap{N,E}(f). SoE = falselands in theNslot and we getMethodError: no method matching (FwdMap{false, E, T} where ...). Anyf.(x)fails;mapand scalar code are fine. The typo is still present on Diffractormain.copy(::IRCode)). Diffractormain(unreleased v0.2.11) does not load on 1.12 either (MethodList has no field mt), though it does on 1.13-rc3. DI cannot fix this.Changes
Diffractor.FwdMap{E}(f)constructor. This is type piracy, flagged as such in the code and docs; it is safe because compat is pinned to a single Diffractor version.Diffractor = "=0.2.6"→"=0.2.10".Diffractorbackend test group (same scenarios as before its removal in chore: revamp testing CI with dedicated environments #926, plus a non-regression test for broadcasting) and reactivate it in CI on Julia 1.10 only (the matrix is 1.10 / 1.12 / 1.13, and the last two are excluded for this group).Testing
Draft PRs skip Julia 1.10 in CI, so the Diffractor group does not run here until the PR is marked ready. Ran the group locally: 3425/3425 tests pass on both Julia 1.10.11 and 1.11.9.
Possible follow-up
A one-line upstream PR to Diffractor (
FwdMap{E}→FwdMap{N,E}) would let us drop the piracy once released.Generated with Claude Opus 5.5 (
claude-opus-5-5).🤖 Generated with Claude Code
https://claude.ai/code/session_017t9zghYPb67WRAZPDhMCNt