Skip to content

[access-host-startup] - Construct access graph before StartupSplashRunner #1562

Description

@JoshuaRowePhantom

Part of #1507 and master #1505

Parent

Dependencies

Summary

Move host construction and LoadingWindow binding before initialization begins.

Current Limitation / Root Cause

The current App startup creates the loading window before access services and cannot show blocking rows.

Affected Files

Path Change
Phantom.Workspaces/App.axaml.cs Implement the bounded production change owned by this issue.
Phantom.Workspaces/ViewModels/LoadingWindowViewModel.cs Implement the bounded production change owned by this issue.
Focused test file Add only the tests listed below.

Design / Fix

This slice implements the following exact contract:

internal static AccessHostServices CreateAccessHostBeforeStartup(
    AccessHostOptions options);

Bind the shared rows in Bootstrap mode before RunWithSplashDismissAsync. Partial construction unwinds on startup failure.

Use required-init properties and named object initializers. The commit must build and its focused tests must pass without relying on a second implementation slice landing in the same commit.

Security and Privacy Invariants

  • Release/use authorization occurs before material access or provider interaction whenever this slice can reach either boundary.
  • No token, secret value, OAuth state, verifier, authorization URL, signed URL, device code, callback, account name, unsafe identifier, or credential-bearing result enters UI-safe state, logs, notifications, entities, or persistence.
  • Typed results remain caller-owned and disposable; provider/cache artifacts remain executor-owned.
  • Errors are typed and sanitized; no broad catch or success-shaped fallback is introduced.

Exclusions

  • No batch API, compatibility bridge, legacy-data migration, silent interactive renewal, or unrelated provider work.
  • No production types beyond the bounded files/classes named here.
  • No UI work unless this issue is explicitly a UI slice.

Commit Plan

Commit 1 — [access-host-startup] - Construct access graph before StartupSplashRunner

Production scope: Phantom.Workspaces/App.axaml.cs, Phantom.Workspaces/ViewModels/LoadingWindowViewModel.cs.

Tests: MainWindowIntegrationTests methods listed below.

Acceptance: one small coherent commit; no opportunistic adjacent migration.

Expected Tests

Test Name Class What It Verifies
ApplicationStartup_BeforeSplashRunner_CreatesAccessHost MainWindowIntegrationTests Verifies the named contract and leaves adjacent slices independently testable.
ApplicationStartup_BeforeInitialize_BindsSharedRowsToLoadingWindow MainWindowIntegrationTests Verifies the named contract and leaves adjacent slices independently testable.
ApplicationStartup_AccessHostConstructionFailure_DisposesPartialGraph MainWindowIntegrationTests Verifies the named contract and leaves adjacent slices independently testable.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    diagnosedRoot cause identifiedenhancementNew feature or request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions