Skip to content

[Feat] 프론트 배포 주소 cors에 추가#58

Merged
shinae1023 merged 1 commit into
mainfrom
fix/#38-job-extract
May 22, 2026
Merged

[Feat] 프론트 배포 주소 cors에 추가#58
shinae1023 merged 1 commit into
mainfrom
fix/#38-job-extract

Conversation

@shinae1023
Copy link
Copy Markdown
Member

@shinae1023 shinae1023 commented May 22, 2026

✨ 어떤 이유로 PR를 하셨나요?

  • feature 병합
  • 버그 수정(아래에 issue #를 남겨주세요)
  • 코드 개선
  • 코드 수정
  • 배포
  • 기타(아래에 자세한 내용 기입해주세요)

📋 세부 내용 - 왜 해당 PR이 필요한지 작업 내용을 자세하게 설명해주세요

📸 작업 화면 스크린샷

⚠️ PR하기 전에 확인해주세요

  • 로컬테스트를 진행하셨나요?
  • 머지할 브랜치를 확인하셨나요?
  • 관련 label을 선택하셨나요?

🚨 관련 이슈 번호 [ ]

Summary by CodeRabbit

  • Chores
    • Updated security configuration to support cross-origin requests from an additional deployment environment.

Review Change Stack

@shinae1023 shinae1023 self-assigned this May 22, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 22, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 7424243f-a6b9-4f3c-a04d-a4fd85436de0

📥 Commits

Reviewing files that changed from the base of the PR and between a8091ef and 5377ddd.

📒 Files selected for processing (1)
  • src/main/java/com/jobdri/jobdri_api/global/config/SecurityConfig.java

📝 Walkthrough

Walkthrough

A single CORS configuration line is added to allow the Vercel-hosted frontend at https://job-dri.vercel.app to communicate with the backend API. The change updates the security configuration's allowed origins list.

Changes

CORS Configuration Update

Layer / File(s) Summary
Allow Vercel deployment CORS origin
src/main/java/com/jobdri/jobdri_api/global/config/SecurityConfig.java
The corsConfigurationSource() method adds https://job-dri.vercel.app to the allowedOrigins list, enabling the Vercel-deployed frontend to make cross-origin requests to the backend API.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A Vercel home, so shiny and new,
Now CORS grants passage, a cross-origin view,
One line, one origin, one hop away,
The frontend and backend can now talk and play! 🎉

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description uses the required template structure but contains no actual content in the key sections (motivation, detailed changes, screenshots, pre-merge confirmation). Fill in the required sections: select a reason (appears to be feature/deployment), provide detailed explanation of why the CORS change is needed, confirm local testing, and reference any related issues.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: adding a frontend deployment URL to CORS configuration.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/#38-job-extract

Comment @coderabbitai help to get the list of available commands and usage tips.

@shinae1023 shinae1023 merged commit 403db37 into main May 22, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant