[Refactor] DTOs to records and drop ingest tone#46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ 어떤 이유로 PR를 하셨나요?
📋 세부 내용 - 왜 해당 PR이 필요한지 작업 내용을 자세하게 설명해주세요
작업 내용
job-posting ingest요청 DTO를record로 정리해 mutablesetter의존을 제거했습니다.tone필드를 제거하고, 생성 프롬프트에는null로 전달되도록 정리했습니다.JobPostingExtractResponse,JobPostingGenerateResponse,JobPostingClassificationResultResponse를record로 전환했습니다.JobPostingAiService의 응답 후처리를 setter 기반 수정 방식에서 새 객체를 반환하는 방식으로 리팩터링했습니다.MockApplyController의 ACTUAL API Swagger 설명을 보완해, 공고 추출/저장/사용자 확인 이후 저장된 공고 ID로 지원이 생성되는 흐름을 명시했습니다.변경 이유
tone입력을 제거해 요청 스펙을 단순화했습니다.📸 작업 화면 스크린샷
🚨 관련 이슈 번호 [#38]