Fix dead code in calculateStreak function to restore grace-period check#8174
Open
nishupr wants to merge 1 commit into
Open
Fix dead code in calculateStreak function to restore grace-period check#8174nishupr wants to merge 1 commit into
nishupr wants to merge 1 commit into
Conversation
Contributor
|
Someone is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
This pull request addresses a critical bug by removing a line of code that was overwriting the grace-period check in the calculateStreak function. This change is essential for ensuring that users receive accurate streak statuses based on their contributions. Similar decisions have been validated in the past, confirming the importance of this fix. Thank you for your contribution, and I look forward to your updates! |
retenta-bot
Bot
changed the title
github-actions
Bot
added
the
status:blocked
…iod check (JhaSourav07#8117) The if/else block correctly set todayIndex = -1 when gapDays exceeded the grace period, but a trailing unconditional line immediately reset it to lastIndex, making the grace-period rejection dead code. Every streak was treated as active regardless of the gap. Fix: deleted the stray todayIndex = lastIndex line after the if/else. Tests: updated 6 test files whose calculateStreak() calls used hardcoded 2024 dates with no 'now' param — they relied on the buggy overwrite to produce positive streaks against stale calendars. Each now passes the correct date so assertions reflect actual intended behaviour.
nishupr
force-pushed
the
fix/calculate-dead-grace-period-8117
branch
from
July 18, 2026 13:21
0e37db8 to
4adbdfd
Compare
github-actions
Bot
removed
the
status:blocked
Contributor
📦 Next.js Bundle Size Report (Gzipped Sizes)✨ No significant bundle size changes detected. 📊 Summary of Totals
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8117
The
if/elseblock incalculateStreakcorrectly settodayIndex = -1when the gap between the last commit and today exceeded the grace period — but a trailing unconditionaltodayIndex = lastIndexline immediately overwrote that result, making the grace-period rejection completely dead code. Every streak was treated as active regardless of the gap.Fix: deleted the stray
todayIndex = lastIndexline after theif/elseblock.Tests: updated 10 tests that called
calculateStreak()with nonowparam — they relied on the buggy overwrite to produce positive streaks against stale2024-01-xxcalendars. Each now passes an explicitnowdate matching the last day of its calendar, making the test intent clear and independent of the real wall clock.Pillar
Visual Preview
N/A — this is a logic bug fix with no visual output change.
Checklist before requesting a review:
CONTRIBUTING.mdfile.localhost:3000/api/streak?user=YOUR_USERNAME).npm run formatandnpm run lintlocally and resolved all errors (CI will fail otherwise).feat(themes): ...,fix(calculate): ...).README.mdif I added a new theme or URL parameter.