Skip to content

test(CustomizeCTA): add timezone boundary test coverage#8088

Open
Shikhartiwari967 wants to merge 3 commits into
JhaSourav07:mainfrom
Shikhartiwari967:test-customizecta-timezone-boundaries
Open

test(CustomizeCTA): add timezone boundary test coverage#8088
Shikhartiwari967 wants to merge 3 commits into
JhaSourav07:mainfrom
Shikhartiwari967:test-customizecta-timezone-boundaries

Conversation

@Shikhartiwari967

Copy link
Copy Markdown
Contributor

Description

Fixes #6825

Added a new test suite for CustomizeCTA to verify timezone normalization and calendar data boundary behavior.

Changes

  • Added CustomizeCTA.timezone-boundaries.test.tsx
  • Mocked multiple timezone environments (UTC, IST, EST, JST)
  • Verified consistent component rendering across different timezones
  • Ensured timezone changes do not affect component stability
  • Added 5 isolated Vitest test cases

Pillar

  • 🎨 Pillar 1 — New Theme Design
  • 📐 Pillar 2 — Geometric SVG Improvement
  • 🕐 Pillar 3 — Timezone Logic Optimization
  • 🛠️ Other (Test Coverage)

Visual Preview

N/A (Test-only changes)

Checklist before requesting a review:

  • I have read the CONTRIBUTING.md file.
  • I have tested these changes locally.
  • I have run npm run lint locally.
  • My commit follows the Conventional Commits format.
  • I have updated README.md if required (not applicable).
  • I have starred the repository.
  • I have made sure that I have only one commit in this PR.
  • This PR only adds automated test coverage.
  • The new test suite passes locally (5/5 tests).

Notes

npm run typecheck currently reports existing repository-wide TypeScript issues (e.g. lib/rss.ts and app/generator/components/*) that are unrelated to this test-only change.

@vercel

vercel Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

@Shikhartiwari967 is attempting to deploy a commit to the jhasourav07's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added the status:blocked This PR is blocked due to a failing CI check. label Jul 15, 2026
@Shikhartiwari967

Copy link
Copy Markdown
Contributor Author

Hi @Aamod007 sir,

The new CustomizeCTA.timezone-boundaries.test.tsx test suite passes locally (5/5 tests), and the component-specific tests run successfully.

The current CI failure appears to come from existing repository-wide TypeScript issues in:

app/generator/components/EditorPanel.type-compiler.test.tsx
app/generator/components/PreviewPanel.type-compiler.test.tsx

These files are outside the scope of this PR, which only adds timezone boundary test coverage for CustomizeCTA.

Please let me know if any changes are needed from my side. Thank you!

@Shikhartiwari967

Copy link
Copy Markdown
Contributor Author

Hi @Aamod007 sir, please review it.

@Aamod007 Aamod007 added level:intermediate Moderate complexity tasks quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. type:testing Adding, updating, or fixing tests mentor:Aamod007 labels Jul 17, 2026

@Aamod007 Aamod007 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work adding the timezone boundary tests for CustomizeCTA to ensure it renders consistently across different locales like IST, EST, JST, and UTC. However, this PR is currently blocked due to a failing CI check. Please resolve the issues and rerun the CI pipeline.

@github-actions github-actions Bot removed the status:blocked This PR is blocked due to a failing CI check. label Jul 17, 2026
@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Size Report (Gzipped Sizes)

✨ No significant bundle size changes detected.

📊 Summary of Totals

Category PR Size Base Size Difference
Total JS 3975.85 KB 3975.85 KB 0 B
Total CSS 331.16 KB 331.16 KB 0 B

@Shikhartiwari967

Copy link
Copy Markdown
Contributor Author

Hi @Aamod007 sir , please review and merge it.

@Aamod007 Aamod007 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test assertions here are a bit odd. It changes the timezone and then tests a completely random element in each block (e.g., it checks for the title in UTC, the link in IST, etc.). If \CustomizeCTA\ doesn't actually display any dates or time-dependent data, these timezone tests might not be providing much value. If the goal is just to ensure rendering doesn't break across timezones, it would be better to assert the exact same core elements in each timezone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

level:intermediate Moderate complexity tasks mentor:Aamod007 quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. type:testing Adding, updating, or fixing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(CustomizeCTA-timezone-boundaries): verify Timezone Normalization & Calendar Data Boundary Alignment (Variation 8)

2 participants