test(CustomizeCTA): add timezone boundary test coverage#8088
test(CustomizeCTA): add timezone boundary test coverage#8088Shikhartiwari967 wants to merge 3 commits into
Conversation
|
@Shikhartiwari967 is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi @Aamod007 sir, The new CustomizeCTA.timezone-boundaries.test.tsx test suite passes locally (5/5 tests), and the component-specific tests run successfully. The current CI failure appears to come from existing repository-wide TypeScript issues in: app/generator/components/EditorPanel.type-compiler.test.tsx These files are outside the scope of this PR, which only adds timezone boundary test coverage for CustomizeCTA. Please let me know if any changes are needed from my side. Thank you! |
|
Hi @Aamod007 sir, please review it. |
Aamod007
left a comment
There was a problem hiding this comment.
Nice work adding the timezone boundary tests for CustomizeCTA to ensure it renders consistently across different locales like IST, EST, JST, and UTC. However, this PR is currently blocked due to a failing CI check. Please resolve the issues and rerun the CI pipeline.
📦 Next.js Bundle Size Report (Gzipped Sizes)✨ No significant bundle size changes detected. 📊 Summary of Totals
|
|
Hi @Aamod007 sir , please review and merge it. |
Aamod007
left a comment
There was a problem hiding this comment.
The test assertions here are a bit odd. It changes the timezone and then tests a completely random element in each block (e.g., it checks for the title in UTC, the link in IST, etc.). If \CustomizeCTA\ doesn't actually display any dates or time-dependent data, these timezone tests might not be providing much value. If the goal is just to ensure rendering doesn't break across timezones, it would be better to assert the exact same core elements in each timezone.
Description
Fixes #6825
Added a new test suite for
CustomizeCTAto verify timezone normalization and calendar data boundary behavior.Changes
CustomizeCTA.timezone-boundaries.test.tsxPillar
Visual Preview
N/A (Test-only changes)
Checklist before requesting a review:
CONTRIBUTING.mdfile.npm run lintlocally.README.mdif required (not applicable).5/5tests).Notes
npm run typecheckcurrently reports existing repository-wide TypeScript issues (e.g.lib/rss.tsandapp/generator/components/*) that are unrelated to this test-only change.