test(DescriptionSection): add mock integration tests#8087
test(DescriptionSection): add mock integration tests#8087Robo-Synaptic-Vaish wants to merge 1 commit into
Conversation
|
🚨 Hey @Robo-Synaptic-Vaish, the CI Pipeline is failing on this PR and it has been marked as Please fix the issues before this can be reviewed. Here's how: 1. Run checks locally before pushing: npm run format:check # Check Prettier formatting
npm run lint # Run ESLint
npm run typecheck # TypeScript type check
npm run test # Run unit tests (Vitest)
npm run build # Verify production build passes2. Auto-fix common issues: npm run format # Auto-fix formatting with Prettier
npm run lint -- --fix # Auto-fix lint errors where possible3. Check the full failure log here: Once you push a fix and the CI passes, the |
Aamod007
left a comment
There was a problem hiding this comment.
Excellent implementation of mock integration tests for the DescriptionSection component. Testing the input constraints and field label interactions ensures a stable component behavior. However, this PR is blocked by a failing CI check. Please resolve the issues and rerun the CI pipeline.
|
If you are still working on this, please push your latest changes or leave a comment to keep it active. |
Fixes #6939
Note
While working on this test, I noticed that
DescriptionSection.tsxcurrently does not include any asynchronous service calls, cache handling, database retrieval, or loading states.So instead of adding mocks for functionality that is not present in the component, the tests focus on the integrations that actually exist:
SectionCardandFieldLabelfor isolated testingonChangebehavior and character limit handlingThis keeps the test coverage aligned with the current implementation of
DescriptionSection.Pillar
Visual Preview
N/A (Test-changes only).
Checklist before requesting a review:
CONTRIBUTING.mdfile.localhost:3000/api/streak?user=YOUR_USERNAME).npm run formatandnpm run lintlocally and resolved all errors (CI will fail otherwise).feat(themes): ...,fix(calculate): ...).README.mdif I added a new theme or URL parameter.