Skip to content

fix: return all transcript sources from recording detail - #6

Merged
devin-ai-integration[bot] merged 5 commits into
mainfrom
devin/1795130911-multi-source-transcripts
Nov 20, 2026
Merged

devin-ai-integration[bot] merged 5 commits into
mainfrom
devin/1795130911-multi-source-transcripts

Conversation

@JeremyL691

@JeremyL691 JeremyL691 commented Nov 19, 2026 •

Copy link
Copy Markdown
Owner

Summary

GET /api/recordings/:id selected LIMIT 1 and returned only transcription, so the web transcript source switcher (which reads transcriptions) could never show older Plaud/provider sources, and the preferred transcript source setting was not applied.

  • Detail now returns transcriptions: every transcript the caller owns, preferred source first, then newest created_at, then id. transcription stays as the first item (or null) for compatibility.
  • recording-detail.tsx keeps the active source button aligned with the shown transcript if a selected source disappears.
  • spec/recordings.md, spec/ui-library.md, CHANGELOG.md updated.

How I tested it

  • New test detail_returns_all_sources_in_preferred_order (ordering with default/custom/missing preferred source, empty/single, ownership isolation, malformed ciphertext). Server suite in rust:1.94.1-trixie: 345 passed, 1 ignored.
  • Against a running server with a two-source fixture, the old endpoint returned keys recording, transcription only.
  • npm run typecheck && npm run build pass. Not verified in a real browser.

Note: this and the web reliability PR both add an Unreleased CHANGELOG section; the second to merge may need a trivial conflict fix.

Checklist

  • Commit messages follow Conventional Commits.
  • Behavior changes update the matching file in spec/ and the tests that pin it.
  • Documentation in docs/ is updated for user-visible changes. (n/a)
  • The entry under Unreleased in CHANGELOG.md is updated for user-visible changes.
  • No secrets, personal data, recordings or generated files are included.

Anita opened this PR for Jeremy
Implemented in session Find and fix bugs in OpenAudioHub web app
Review with Devin · Open in Devin Desktop


Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

@devin-ai-integration devin-ai-integration Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@devin-ai-integration
devin-ai-integration Bot merged commit 795ff62 into main Nov 20, 2026
11 checks passed
devin-ai-integration Bot pushed a commit that referenced this pull request Nov 20, 2026
* fix: expose all recording transcript sources in preferred order

* fix(recordings): search all transcript sources and cover source ordering
@devin-ai-integration
devin-ai-integration Bot deleted the devin/1795130911-multi-source-transcripts branch November 20, 2026 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant