Repository navigation
feat(plaud): support Plaud 4.0 sync and release 1.7.0 - #11
Conversation
bbf9df1 to
22c1123
Compare
…e migration and detail-only versions
There was a problem hiding this comment.
Devin Review found 1 new potential issue.
6 flags not posted on this PR by your GitHub settings — view them in Devin Review. (Configure)
| if prev == version_text(&hydrated) { | ||
| let imported = import_for(state, ctx, &id, &hydrated.id).await; | ||
| return Ok(Outcome::Unchanged { imported }); | ||
| } |
There was a problem hiding this comment.
🟡 Later Plaud edits skipped indefinitely
When Plaud lists a recording without timestamps or a version, process can only detect its edit from detail. The edit cannot move it up in the sync order. If sync_pages stops after two unchanged pages, later edits stay unsynced across runs.
Learn more
Plaud 4.0 sync fetches a list of recordings, then examines it in batches of 50. map_list_item and sort_recordings_desc use list fields for ordering, so a recording without timestamps or a version stays at the end even when its detail version changes. apply_detail recovers that version only after sync reaches the recording. Matching the stored version after hydration makes a page count as idle unless it also imports content. sync_pages stops after two idle pages, so an edited recording beyond that cutoff is never checked as long as the first two pages stay idle.
Example: Sync a library with 99 dated recordings followed by two recordings that have versions only in detail. All 101 import. Rename the last recording in Plaud. Its list position does not change, so the next sync checks only the first 100 and leaves the old title in OpenAudioHub.
Recommended fix: Skip the two-idle-page cutoff when the cached Plaud 4.0 list contains entries whose ordering cannot reflect edits. Use the full cached list to make that decision before processing pages, since the first sparse entry can be beyond the cutoff. Add a multi-page regression test that changes only a detail version and title beyond the first 100 entries.
Was this helpful? React with 👍 or 👎 to provide feedback.
Summary
/file-app/v4/) while keeping non-migrated accounts on the existing/file/routes.status: -1800907(or amigrated to 4.0message) without schema changes or reconnection.of_<id>file ids back to storedplaud_file_idrows and tombstones, while importing newf_<id>recordings with lazy detail hydration (serial_number,filesize, IANAtimezone_ianaoffsets, and download size/MD5 fallback).AUDIO_TRANSCODED, fallback toAUDIO, plus/file-app/v4/files/content/url), mid-sync workspace token re-minting on-419/-420, Plaud-native content import (including gzipped Markdown summaries and migratedtask_status: nullobjects), title push via/file-app/v4/nodes/rename/{node_id}with-1800313retry and container folder rename, and/device/list-1800907connect fallback.Sync failed:prefix in the manual sync error toast.spec/plaud.md,spec/desktop.md,CHANGELOG.md, fake Plaud server, contract tests, and workspace version files to1.7.0.Testing
rustup run 1.94.1 cargo fmt --all -- --checkrustup run 1.94.1 cargo clippy --workspace --all-targets -- -D warningsrustup run 1.94.1 cargo test -p oah --lib(321 passed)rustup run 1.94.1 cargo test -p oah --tests(358 passed)rustup run 1.94.1 cargo test -p openaudiohub-desktop(34 passed)pnpm --dir web typecheck && pnpm --dir web buildpnpm --dir extension typecheck && pnpm --dir extension testbash contract-tests/run.sh server --grep "plaud" --reporter=line(57 passed)bash contract-tests/run.sh server --reporter=line(464 passed, 2 skipped)tools/check/rust-version.sh