Repository navigation
Add a security warning for from_string() (CVE-2025-26240) - #281
Open
marquis-wkhtmltopdf wants to merge 1 commit into
Open
marquis-wkhtmltopdf wants to merge 1 commit into
marquis-wkhtmltopdf wants to merge 1 commit into
Conversation
from_string() reads <meta name="pdfkit-..."> tags as wkhtmltopdf options (CVE-2025-26240). Add a Security section to the README and warnings to the docstrings. Closes JazzCore#267
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #267.
from_string()reads<meta name="pdfkit-...">tags as wkhtmltopdf options, so untrusted HTML can set any option, including ones that read files or run JavaScript (CVE-2025-26240). The docs don't warn about this.This adds a short Security section to the README and warnings to the docstrings of
from_string(),from_url(),from_file()andPDFKit. Docs only. It complements #276 (a code fix): the advice on JavaScript, local files and isolation applies either way.Checked on wkhtmltopdf 0.12.6.1, 0.12.6 and 0.12.5, with pdfkit master and 1.0.0: only
from_string()reads meta tags, the README example runs and blocks scripts and local files, and the tests pass.