Skip to content

Add a security warning for from_string() (CVE-2025-26240) - #281

Open
marquis-wkhtmltopdf wants to merge 1 commit into
JazzCore:masterfrom
marquis-wkhtmltopdf:security-docs
Open

marquis-wkhtmltopdf wants to merge 1 commit into
JazzCore:masterfrom
marquis-wkhtmltopdf:security-docs

Conversation

@marquis-wkhtmltopdf

Copy link
Copy Markdown

Closes #267.

from_string() reads <meta name="pdfkit-..."> tags as wkhtmltopdf options, so untrusted HTML can set any option, including ones that read files or run JavaScript (CVE-2025-26240). The docs don't warn about this.

This adds a short Security section to the README and warnings to the docstrings of from_string(), from_url(), from_file() and PDFKit. Docs only. It complements #276 (a code fix): the advice on JavaScript, local files and isolation applies either way.

Checked on wkhtmltopdf 0.12.6.1, 0.12.6 and 0.12.5, with pdfkit master and 1.0.0: only from_string() reads meta tags, the README example runs and blocks scripts and local files, and the tests pass.

from_string() reads <meta name="pdfkit-..."> tags as wkhtmltopdf
options (CVE-2025-26240). Add a Security section to the README and
warnings to the docstrings.

Closes JazzCore#267
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Security Concerns (CVE-2025-26240)

1 participant