Skip to content

Cosmetics: fix units in labels - #226

Open
floesche wants to merge 2 commits into
JaneliaSciComp:masterfrom
floesche:development-tethered
Open

Cosmetics: fix units in labels#226
floesche wants to merge 2 commits into
JaneliaSciComp:masterfrom
floesche:development-tethered

Conversation

@floesche

@floesche floesche commented May 7, 2026

Copy link
Copy Markdown
Collaborator

Just some small cosmetics, but I believe the unit are in cm at that point? Or is that only in certain cases, not generally?

@hubbardp

hubbardp commented May 7, 2026

Copy link
Copy Markdown
Collaborator

I'll have to check with Hannah. She has been using this as-is for years.

@floesche

floesche commented May 7, 2026

Copy link
Copy Markdown
Collaborator Author

This is not changing functionality, just the labels. At least in the use case when there are fly models in the scene, I understood that the measurements are in cm. If that is different in other cases (which I don't know), we should either find a way to somehow push the units, for example from the configuration json, or remove the units entirely?

@hubbardp

hubbardp commented May 7, 2026

Copy link
Copy Markdown
Collaborator

I think some of the confusion is because we switch units to cm to match the MuJoCo fly model. So for "Offset X", "Offset Z", "Near" and "Far" it probably should say "(scene units)" instead of "(mm)" or "(cm)". For the screen units it may be only the ratio that matters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants