fix: recover Core synchronous Git reconciliation without blind retry - #189
Merged
James3014 merged 1 commit intoSep 17, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a Core-bound
git_commitfailure mode found during the Nexus Runtime Wave B1 managed replay. A deterministic pre-effect rejection such as an incomplete Candidate path set could previously admit theSYNCHRONOUS_GITwriter first, leave the session inOUTCOME_UNKNOWN, and permanently wedge later valid commits.The change moves physical scope/deletion/path-set preconditions ahead of synchronous Git admission. For already-stranded sessions it reuses the existing physical reconciliation path, clears only the exact unresolved synchronous writer, and returns
CORE_MUTATION_RECONCILED_RETRY_REQUIRED; the recovery call never automatically retries or creates a commit.The production change is limited to
src/server.ts, with regression coverage insrc/server.test.ts. Independent verification against exact head07b274cdff1982d704d1b09da103885bbb7b191bpassed the five hostile wedge cases, full server/Core/Git Candidate suites, typecheck, diff-check, and the full repositorynpm test(exit 0; one pre-existing environment-conditional macOS/varalias skip was observed in the full suite).