Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wave 4 live G2 on #117 reproduced a false-positive send acknowledgement in the managed CDP carrier. The runtime entered
waitForConversationUrl()even though the fresh Project target remained on the Project URL and the CDP target census contained no conversation created after the fresh Swarm timestamp. The remaining synthetic seam wasbutton.click(): invoking it was treated as successful delivery without a physical conversation effect.This change keeps the existing
CdpMacWebDriver, exact-target identity fences, Swarm durable authority, andwaitForConversationUrl()acknowledgement. It only replaces DOMbutton.click()with exact-target CDP mouse press/release at the visible enabled send button center. The regression tests require the native CDP mouse events for both editable and textarea composer paths and explicitly reject reintroducingbutton.click().Candidate
69fb12827469e825f13d14f4ee833376884afc85is based on deployedmain@1cb8b42785f40fb8a023872e209155a948fa1088and changes onlysrc/chat-swarm-runtime.tsandsrc/chat-swarm-runtime.test.ts.git diff --checkpasses. Local dependency-backed verification is blocked by the current paired-carrier gate, so exact-head GitHub CI is the dependency-backed verifier before any live G2 rerun.