fix(errors): stop repeating err_code that is already in err_msg#10
Merged
Conversation
Observed in the live response after the previous change:
Deepgram 400: Bad Request: Nova-3 models do not support more than one
alternative. (Bad Request)
Deepgram usually prefixes err_msg with err_code, so appending it
unconditionally stutters. Append only when the code adds information.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cosmetic follow-up to #9, caught in its own live output:
Deepgram usually prefixes
err_msgwitherr_code, so appending it unconditionally stutters. Now appended only when the code adds information; a test pins both directions.113 passed, 1 skipped.