Skip to content

docs(j5): register D48, focus stays in an artifact when the app regains focus - #1164

Open
Jacksondr5 wants to merge 1 commit into
j5/mainfrom
j5code/register-d48-artifact-focus
Open

Jacksondr5 wants to merge 1 commit into
j5/mainfrom
j5code/register-d48-artifact-focus

Conversation

@Jacksondr5

Copy link
Copy Markdown
Owner

Records the one change to upstream behaviour in #1153 (artifact find, #1152) as divergence D48 in docs/j5/product/upstream.md, under Clients. Jackson approved recording it on 2026-11-22.

  • Upstream: shouldRefocusComposerOnWindowFocus (apps/web/src/components/ChatView.logic.ts) moves focus to the composer when the window regains focus, unless it's in a text field, iframe, dialog, menu and a few others.
  • J5: focus inside [data-j5-artifacts-surface] stays put.
  • Why: reading and Cmd/Ctrl+F in an artifact survive switching apps, and the desktop find bar's Esc returns as a window focus.
  • Consequences: one selector in upstream's exclusion list (FORK.md case 126); it can retire if upstream stops refocusing from panel content.
  • Decided: Jackson, 2026-11-22.

Also adds one History line. This PR stands alone: FORK.md case 126 is added by #1153, which has auto-merge on.

Checklist

  • One concern
  • Tests: none needed, docs only
  • UI changes: none
  • Live testing: not applicable
  • Upstream-owned files: none edited
  • Upstream product: the divergence is the register entry itself, with Jackson's decision
  • Surfaces: none
  • Docs: this is the docs change

Claude Opus 5.5 in Claude Code (J5 Code).

🤖 Generated with Claude Code

…e app regains focus

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Nov 22, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
j5-code Ready Ready Preview Nov 22, 2026 6:32pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Nov 22, 2026

Copy link
Copy Markdown

Warning

Review limit reached

  • Run on-demand review

This review includes 1 billable file and costs up to $0.25.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 23 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available. Your 52 included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 5439ac2 and fef671d.

Files selected for processing: 1

  • docs/j5/product/upstream.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@github-actions github-actions Bot added the vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. label Nov 22, 2026
@github-actions github-actions Bot added the size:S 10-29 effective changed lines (test files excluded in mixed PRs). label Nov 22, 2026

This branch was successfully deployed

1 active deployment
Preview — fef671df Deployed Nov 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 effective changed lines (test files excluded in mixed PRs). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant