Repository navigation
fix(web): an Inbox reply says when it can't be saved on this device - #1163
Open
Jacksondr5 wants to merge 2 commits into
Open
Jacksondr5 wants to merge 2 commits into
Jacksondr5 wants to merge 2 commits into
Conversation
When localStorage is full, an Inbox reply's images and words failed to save silently: an image could be sent but was gone after a reload, and the words could be lost too. The answer's image tiles now show the composer's "may not persist" warning for images in the draft's nonPersistedImageIds. The words store wraps its storage so a failed write marks the asks whose words differ from what storage holds, and the reply shows a short note until a later save succeeds. Closes #1141 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
This review includes 4 billable files and costs up to $1.00.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 20 minutes for your next included review. View limit details
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
|
Review round 1, Claude Opus 5.5 and GPT-6.2 Sol. Opus approves; Sol requested changes on findings it rated medium.
|
Jacksondr5
added a commit
that referenced
this pull request
Nov 22, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When localStorage is full (a few large screenshots will do it), an Inbox reply fails to save and says nothing. An image uploads and can be sent, but it's gone after a reload while the words come back. The words can fail to save too. Closes #1141.
What changed
Both states show in
AnswerAttachmentList, which the Inbox page and the Adjudication Dock both render under the reply box, so each surface gets them.nonPersistedImageIds. The Inbox reply's image saves go through the same check, but nothing displayed the result. An image in that list now gets the composer's own warning badge and tooltip, with the same wording and look asComposerAttachmentStrip: "Draft attachment could not be saved locally and may be lost on navigation."j5:inbox-answer-texts:v1) now passes upstream'screateDeferredStoragea thin wrapper around localStorage. That wrapper catches the write that runs after the 300 ms debounce, so the signal is the failed write itself. That covers the flush on unload too, needs no read-back, and leaves upstream'screateDeferredStorageunedited.All the changes are in J5 files (
inboxAnswerDrafts.tsandAnswerAttachments.tsx).Left out: drafts for a removed connection staying in storage, which is a separate cleanup.
Surfaces: the Inbox page and the Adjudication Dock, on web and desktop. Mobile isn't affected: it keeps its reply in its own store (#1139).
UI changes
Same fixture, viewport and theme on both sides. Storage was filled in the test page only. "Before" is j5/main, and "after" is 6b74b99. The later commit, 42ce6c3, only adds
role="status"to the note.Reply text with localStorage full. Before: nothing says the reply isn't saved. After: a note under the reply box.
Image attached with localStorage full. Before: a plain thumbnail. After: upstream's composer warning badge on the thumbnail, with the tooltip "Draft attachment could not be saved locally and may be lost on navigation."
Live testing
Verdict: pass. An independent GPT-6.2 Sol tester ran it as a Peer Agent in its own worktree, on isolated servers from
setup-agent-live-test.ts, with real Claude Haiku 5.5 asks. Storage was filled and cleared in the test page only.Not exercised: desktop (Electron). It renders the same web component and storage.
Checklist
FORK.md(case text and file-table row) in this PR (none edited)docs/j5/product/upstream.md(no change to upstream's product)AGENTS.md)docs/j5/product/and user docs rewritten where this changes them (no doc describes this)Implemented by Claude Opus 5.5 in Claude Code (J5 Code).
🤖 Generated with Claude Code