Repository navigation
Check dependency licenses with cargo-deny in CI - #15
Merged
Merged
Conversation
Datadog's open source review requires an automated license policy. The allow-list holds the permissive licenses the dependency graph uses today; a crate offering several licenses passes when one is allowed. cargo-deny is installed from crates.io at a fixed version instead of through a third-party action, which the DataDog organization's Actions policy may not allow. Cargo.toml now declares the crate's own license so it is not reported as unlicensed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
rust/conduit/deny.tomlwith a permissive allow-list: Apache-2.0, Apache-2.0 WITH LLVM-exception, BSD-3-Clause, MIT, Unicode-3.0. A crate offering several licenses passes when one of them is allowed.licensesworkflow that installscargo-deny@0.19.5withcargo install --locked(no third-party action) and runscargo deny check licenses.license = "Apache-2.0"inCargo.tomlso the crate itself is not reported as unlicensed.Checks:
cargo deny check licensespasses locally, with and without--all-features; removing MIT from the allow-list rejects 36 crates; actionlint is clean;bazel test //...passes.foldhash(Zlib) appears inCargo.lockthrough a feature-gatedhashbrown@0.15.5edge that Cargo and Bazel do not activate, so Zlib is intentionally not allowed. This PR's ownlicensesrun confirms that on the CI runner.Part of preparing conduit for transfer to the DataDog organization as an open source repository.
Checklist