webhooks: Clean up bot config and creation forms. - #8
Open
JDoe-code wants to merge 15 commits into
Open
Conversation
Add validate_webhook_delivery to parse request signatures and handle JsonableError exceptions during payload verification. Tested with: ./tools/test-backend zerver/tests/test_webhooks_common.py Co-authored-by: Srinandha Murugesan <srinandhamurugesan@gmail.com> Co-authored-by: Isaiah Marte <JDoe-code@users.noreply.github.com> Co-authored-by: Akshaj Katkuri <Akshaj-Katkuri@users.noreply.github.com> Co-authored-by: Jason Zheng <jasonzheng13@users.noreply.github.com>
Update WebhookTestCase to generate HMAC signatures when testing signed webhook payloads. Update GitHub webhook tests accordingly. Tested with: ./tools/test-backend zerver/webhooks/github/ Co-authored-by: Srinandha Murugesan <srinandhamurugesan@gmail.com> Co-authored-by: Isaiah Marte <JDoe-code@users.noreply.github.com> Co-authored-by: Akshaj Katkuri <Akshaj-Katkuri@users.noreply.github.com> Co-authored-by: Jason Zheng <jasonzheng13@users.noreply.github.com>
Add webhook secret field options to integration definitions and dev panel UI. Synchronize header recalculation on user input. Tested via dev panel frontend UI and ./tools/lint. Co-authored-by: Srinandha Murugesan <srinandhamurugesan@gmail.com> Co-authored-by: Isaiah Marte <JDoe-code@users.noreply.github.com> Co-authored-by: Akshaj Katkuri <Akshaj-Katkuri@users.noreply.github.com> Co-authored-by: Jason Zheng <jasonzheng13@users.noreply.github.com>
Add backend recalculate_signature view and signature registry for dev panel UI recalculation. Add unit tests for signature hashing. Tested with: ./tools/test-backend zerver/tests/test_integrations_dev_panel.py Co-authored-by: Srinandha Murugesan <srinandhamurugesan@gmail.com> Co-authored-by: Isaiah Marte <JDoe-code@users.noreply.github.com> Co-authored-by: Akshaj Katkuri <Akshaj-Katkuri@users.noreply.github.com> Co-authored-by: Jason Zheng <jasonzheng13@users.noreply.github.com>
Invoke validate_webhook_delivery in GitHub webhook handler view and register dev recalculate_signature endpoint in zproject dev URLs. Tested with: ./tools/test-backend zerver/webhooks/github/ Co-authored-by: Srinandha Murugesan <srinandhamurugesan@gmail.com> Co-authored-by: Isaiah Marte <JDoe-code@users.noreply.github.com> Co-authored-by: Akshaj Katkuri <Akshaj-Katkuri@users.noreply.github.com> Co-authored-by: Jason Zheng <jasonzheng13@users.noreply.github.com>
Sanitize the error response in recalculate_signature to prevent exposing internal stack traces or server implementation details via raw exception strings. Co-authored-by: Srinandha Murugesan <srinandhamurugesan@gmail.com> Co-authored-by: Isaiah Marte <JDoe-code@users.noreply.github.com> Co-authored-by: Akshaj Katkuri <Akshaj-Katkuri@users.noreply.github.com> Co-authored-by: Jason Zheng <jasonzheng13@users.noreply.github.com>
Co-authored-by: Srinandha Murugesan <srinandhamurugesan@gmail.com> Co-authored-by: Isaiah Marte <JDoe-code@users.noreply.github.com> Co-authored-by: Akshaj Katkuri <Akshaj-Katkuri@users.noreply.github.com> Co-authored-by: Jason Zheng <jasonzheng13@users.noreply.github.com>
Srinandha-Murugesan
force-pushed
the
19773-new-changes
branch
from
July 27, 2026 23:22
975b584 to
cc7c4a0
Compare
JDoe-code
force-pushed
the
19773-new-changes
branch
3 times, most recently
from
July 29, 2026 19:44
2844fc6 to
b6dd6c3
Compare
JDoe-code
force-pushed
the
19773-new-changes
branch
from
July 29, 2026 23:01
b6dd6c3 to
cf93405
Compare
Srinandha-Murugesan
force-pushed
the
19773-fixed
branch
from
July 30, 2026 18:58
f45069a to
349aa78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addition adds some final touches to the UI of the bot config and creation forms to omit the approaches we were using when we were originally trying to extract the secret from the request URL rather than from BotConfigData.