Cleanded up commit history - #6
Open
Srinandha-Murugesan wants to merge 5 commits into
Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Srinandha-Murugesan
force-pushed
the
19773-fixed
branch
from
July 30, 2026 18:49
7818ac1 to
f45069a
Compare
Remove webhook_secret parameter handling from integration dev panel URL generation now that secrets are handled via bot config. Co-authored-by: Srinandha Murugesan <srinandhamurugesan@gmail.com> Co-authored-by: Isaiah Marte <JDoe-code@users.noreply.github.com> Co-authored-by: Akshaj Katkuri <Akshaj-Katkuri@users.noreply.github.com> Co-authored-by: Jason Zheng <jasonzheng13@users.noreply.github.com>
Add webhook secret field to bot creation and editing modals, allowing users to set, update, or delete the webhook secret stored in BotConfigData. Tested with: ./tools/test-backend zerver/tests/test_bots.py Co-authored-by: Srinandha Murugesan <srinandhamurugesan@gmail.com> Co-authored-by: Isaiah Marte <JDoe-code@users.noreply.github.com> Co-authored-by: Akshaj Katkuri <Akshaj-Katkuri@users.noreply.github.com> Co-authored-by: Jason Zheng <jasonzheng13@users.noreply.github.com>
Update validate_webhook_delivery and validate_webhook_signature to retrieve secrets directly from BotConfigData instead of requiring them in the URL query string. Tested with: ./tools/test-backend zerver/tests/test_webhooks_common.py ./tools/test-backend zerver/webhooks/github/tests.py Co-authored-by: Srinandha Murugesan <srinandhamurugesan@gmail.com> Co-authored-by: Isaiah Marte <JDoe-code@users.noreply.github.com> Co-authored-by: Akshaj Katkuri <Akshaj-Katkuri@users.noreply.github.com> Co-authored-by: Jason Zheng <jasonzheng13@users.noreply.github.com>
Fixed linting issues and updated dependencies. Co-authored-by: Srinandha Murugesan <srinandhamurugesan@gmail.com> Co-authored-by: Isaiah Marte <JDoe-code@users.noreply.github.com> Co-authored-by: Akshaj Katkuri <Akshaj-Katkuri@users.noreply.github.com> Co-authored-by: Jason Zheng <jasonzheng13@users.noreply.github.com>
Srinandha-Murugesan
force-pushed
the
19773-fixed
branch
from
July 30, 2026 18:58
f45069a to
349aa78
Compare
Update code to fix lint errors and duplicate/missing imports. Co-authored-by: Srinandha Murugesan <srinandhamurugesan@gmail.com> Co-authored-by: Isaiah Marte <JDoe-code@users.noreply.github.com> Co-authored-by: Akshaj Katkuri <Akshaj-Katkuri@users.noreply.github.com> Co-authored-by: Jason Zheng <jasonzheng13@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidated commit history into 5 commits