SDK-412 UUA Naming inconsistencies#1049
Open
joaodordio wants to merge 1 commit intomasterfrom
Open
Conversation
joaodordio
force-pushed
the
fix/SDK-412-UUA-Naming-inconsistencies
branch
from
6786581 to
fb254cc
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔹 Jira Ticket(s) if any
✏️ Description
Final piece of the cross-SDK Unknown User Activation (UUA) naming alignment. Android was already consistent with the locked convention everywhere except this one method.
Change
UnknownUserManager.getCriteria()is nowgetUnknownCriteria(). Method is package-private, so all three call sites (two inIterableApi.java, one self-call insideUnknownUserManager.java) are updated in this PR. No deprecated alias needed since there are no external consumers.Everything else (config flag
setEnableUnknownUserActivation,mergeOnUnknownToKnown,itbl_userid_unknown,itbl_unknown_sessions, session JSON field names,eventTypediscriminator) was already correct per the audit.Tests
Existing
IterableApiCriteriaFetchTestsexercises the renamed method through the public API by asserting on the criteria endpoint hit, so coverage is unchanged.