Skip to content

[BUG] TcoInspectionGroup.UpdateComprehensiveResult() duplicates Failures and ErrorCodes #68

Open

Description

@KrisztianOlah

Describe the bug
When the inspection passes it does not replace _refOverallResult.Failures with _currentRunResult.Failures thus concataniting the original with itself.

`CASE _currentRunResult.Result OF
eOverallResult.NoAction:
;
eOverallResult.Passed:
;
eOverallResult.Failed:

	_refOverallResult.Result		:= eOverallResult.Failed;
	_refOverallResult.Failures        := _currentRunResult.Failures; ///should happen for all cases
	_refOverallResult.ErrorCodes	:= _currentRunResult.ErrorCodes; ///should happen for all cases

END_CASE

IF(_done) THEN
///Alternatively we could use _currentRunResult.Failures and _currentRunResult.ErrorCodes to concatenate with _originalOverallResult.Failures and _originalOverallResult.ErrorCodes respectively.
_refOverallResult.Failures :=concat( _originalOverallResult.Failures,_refOverallResult.Failures);
_refOverallResult.ErrorCodes :=concat( _originalOverallResult.ErrorCodes,_refOverallResult.ErrorCodes);
_overallResult := _refOverallResult;

END_IF; `
To Reproduce
Steps to reproduce the behavior:
Run an inspection that fails with a ContinueOnFail() or on another station with a Failure text set, but will be the same with ErrorCodes
Run a new inspection that passes.
The new Failures/ErrorCodes property will be duplicate of itself.

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots

image image

Additional context
Add any other context about the problem here.

Activity

  1. added
    bugSomething isn't working
    questionFurther information is requested
    on Nov 12, 2026
  2. KrisztianOlah commented on Nov 12, 2026

    @KrisztianOlah
    ContributorAuthor

    /cib

  3. github-actions commented on Nov 12, 2026

    @github-actions
    Contributor
  4. added a commit that references this issue on Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingquestionFurther information is requested

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions