You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[BUG] TcoInspectionGroup.UpdateComprehensiveResult() duplicates Failures and ErrorCodes #68
Describe the bug
When the inspection passes it does not replace _refOverallResult.Failures with _currentRunResult.Failures thus concataniting the original with itself.
`CASE _currentRunResult.Result OF
eOverallResult.NoAction:
;
eOverallResult.Passed:
;
eOverallResult.Failed:
_refOverallResult.Result := eOverallResult.Failed;
_refOverallResult.Failures := _currentRunResult.Failures; ///should happen for all cases
_refOverallResult.ErrorCodes := _currentRunResult.ErrorCodes; ///should happen for all cases
END_CASE
IF(_done) THEN
///Alternatively we could use _currentRunResult.Failures and _currentRunResult.ErrorCodes to concatenate with _originalOverallResult.Failures and _originalOverallResult.ErrorCodes respectively.
_refOverallResult.Failures :=concat( _originalOverallResult.Failures,_refOverallResult.Failures);
_refOverallResult.ErrorCodes :=concat( _originalOverallResult.ErrorCodes,_refOverallResult.ErrorCodes);
_overallResult := _refOverallResult;
END_IF; ` To Reproduce
Steps to reproduce the behavior:
Run an inspection that fails with a ContinueOnFail() or on another station with a Failure text set, but will be the same with ErrorCodes
Run a new inspection that passes.
The new Failures/ErrorCodes property will be duplicate of itself.
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
Additional context
Add any other context about the problem here.
Activity
KrisztianOlah commentedon Nov 12, 2026
/cib
github-actions commentedon Nov 12, 2026
Branch 68-_BUG_TcoInspectionGroup_UpdateComprehensiveResult_duplicates_Failures_and_ErrorCodes created!
Create draft PR for #68
Fix failure and error code handling in inspection group