Skip to content

fix: quote annotations shadowed by class members #3654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkoura merged 1 commit into from
Aug 21, 2026
+5 −5
Merged

fix: quote annotations shadowed by class members #3654

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cardano_node_tests/cluster_management/manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ def cluster_instance_num(self) -> int:
return self._cluster_instance_num

@property
def cache(self) -> cache.ClusterManagerCache:
def cache(self) -> "cache.ClusterManagerCache":
return cache.CacheManager.get_instance_cache(instance_num=self.cluster_instance_num)

@property
Expand Down
2 changes: 1 addition & 1 deletion cardano_node_tests/utils/cluster_nodes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ class ClusterType(tp.Protocol):
NODES: tp.ClassVar[frozenset[str]]

type: ClusterKind
cluster_scripts: cluster_scripts.ScriptsTypes
cluster_scripts: "cluster_scripts.ScriptsTypes"

@property
def is_local(self) -> bool:
Expand Down
6 changes: 3 additions & 3 deletions cardano_node_tests/utils/gh_issue.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,11 @@ class GHIssue:

issue_cache: tp.ClassVar[dict[str, str]] = {}

_github_instance: tp.ClassVar[github.Github | None] = None
_github_instance: tp.ClassVar["github.Github | None"] = None
_github_instance_error: tp.ClassVar[bool] = False

@classmethod
def _get_github(cls) -> github.Github | None:
def _get_github(cls) -> "github.Github | None":
"""Get GitHub instance."""
if cls._github_instance is not None:
return cls._github_instance
Expand All @@ -51,7 +51,7 @@ def __init__(self, number: int, repo: str) -> None:
self.repo = repo

@property
def github(self) -> github.Github | None:
def github(self) -> "github.Github | None":
return self._get_github()

@property
Expand Down
Loading