fix(tests): support new Prometheus metric names - #3638
Merged
Conversation
Node 11.1.0 renamed the metrics used by `test_metrics_reconnect`:
integer gauges gained an `_int` suffix and the `peerSelection`
counters are now capitalized. Look the metrics up under both the
new and the old names, so the test keeps working with older nodes.
A missing metric now raises `AssertionError` instead of `KeyError`,
so the existing retry loop covers a counter that is not registered
yet right after a node restart.
Parse the response in a dedicated helper. A metric line is
`name[{labels}] value [timestamp]`, so split the value off after
the labels, ignore comment lines and sum the values of all the
series of a labelled metric.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node 11.1.0 renamed the metrics used by
test_metrics_reconnect: integer gauges gained an_intsuffix and thepeerSelectioncounters are now capitalized. Look the metrics up under both the new and the old names, so the test keeps working with older nodes.A missing metric now raises
AssertionErrorinstead ofKeyError, so the existing retry loop covers a counter that is not registered yet right after a node restart.Parse the response in a dedicated helper. A metric line is
name[{labels}] value [timestamp], so split the value off after the labels, ignore comment lines and sum the values of all the series of a labelled metric.