fix(tests): recognize Dijkstra AllInputsAreSpent - #3637
Merged
Conversation
The Dijkstra era injects the Conway `ConwayMempoolFailure "All inputs are spent."` as its own dedicated `AllInputsAreSpent` failure, so the existing error string checks no longer matched and tests broke on harmless resubmits of a Tx that had already made it to the chain. Add `helpers.is_inputs_spent_err` that accepts all the known era variants and use it in place of the 13 copies of the check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Dijkstra era injects the Conway
ConwayMempoolFailure "All inputs are spent."as its own dedicatedAllInputsAreSpentfailure, so the existing error string checks no longer matched and tests broke on harmless resubmits of a Tx that had already made it to the chain.Add
helpers.is_inputs_spent_errthat accepts all the known era variants and use it in place of the 13 copies of the check.