Skip to content

refactor: use usefixtures marker in tests #3606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkoura merged 1 commit into from
Aug 11, 2026
Merged

refactor: use usefixtures marker in tests #3606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 12 additions & 24 deletions cardano_node_tests/tests/test_env_network_id.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,10 +116,9 @@ class TestNetworkIdEnv:
@allure.link(helpers.get_vcs_link())
@pytest.mark.smoke
@pytest.mark.testnets
@pytest.mark.usefixtures("skip_on_no_env", "set_network_id_env")
def test_query_protocol_state(
self,
skip_on_no_env: None, # noqa: ARG002
set_network_id_env: None, # noqa: ARG002
cluster: clusterlib.ClusterLib,
):
"""Query protocol state using CARDANO_NODE_NETWORK_ID environment variable.
Expand All @@ -140,10 +139,9 @@ def test_query_protocol_state(
@allure.link(helpers.get_vcs_link())
@pytest.mark.smoke
@pytest.mark.testnets
@pytest.mark.usefixtures("skip_on_no_env", "set_network_id_env")
def test_query_stake_distribution(
self,
skip_on_no_env: None, # noqa: ARG002
set_network_id_env: None, # noqa: ARG002
cluster: clusterlib.ClusterLib,
):
"""Query stake distribution using CARDANO_NODE_NETWORK_ID environment variable.
Expand All @@ -164,10 +162,9 @@ def test_query_stake_distribution(
@allure.link(helpers.get_vcs_link())
@pytest.mark.smoke
@pytest.mark.testnets
@pytest.mark.usefixtures("skip_on_no_env", "set_network_id_env")
def test_query_protocol_params(
self,
skip_on_no_env: None, # noqa: ARG002
set_network_id_env: None, # noqa: ARG002
cluster: clusterlib.ClusterLib,
):
"""Query protocol parameters using CARDANO_NODE_NETWORK_ID environment variable.
Expand All @@ -188,10 +185,9 @@ def test_query_protocol_params(
@allure.link(helpers.get_vcs_link())
@pytest.mark.smoke
@pytest.mark.testnets
@pytest.mark.usefixtures("skip_on_no_env", "set_network_id_env")
def test_query_pool_state(
self,
skip_on_no_env: None, # noqa: ARG002
set_network_id_env: None, # noqa: ARG002
cluster: clusterlib.ClusterLib,
):
"""Query pool state using CARDANO_NODE_NETWORK_ID environment variable.
Expand All @@ -210,10 +206,9 @@ def test_query_pool_state(
@allure.link(helpers.get_vcs_link())
@pytest.mark.smoke
@pytest.mark.testnets
@pytest.mark.usefixtures("skip_on_no_env", "set_network_id_env")
def test_query_stake_addr_info(
self,
skip_on_no_env: None, # noqa: ARG002
set_network_id_env: None, # noqa: ARG002
cluster: clusterlib.ClusterLib,
):
"""Query stake address info using CARDANO_NODE_NETWORK_ID environment variable.
Expand All @@ -233,10 +228,9 @@ def test_query_stake_addr_info(
@common.SKIPIF_BUILD_UNUSABLE
@pytest.mark.smoke
@pytest.mark.testnets
@pytest.mark.usefixtures("skip_on_no_env", "set_network_id_env")
def test_build_transfer_funds(
self,
skip_on_no_env: None, # noqa: ARG002
set_network_id_env: None, # noqa: ARG002
cluster: clusterlib.ClusterLib,
payment_addrs: list[clusterlib.AddressRecord],
):
Expand Down Expand Up @@ -299,10 +293,9 @@ def _ignore_log_errors(self) -> None:
@PARAM_ARG_SCENARIO
@pytest.mark.smoke
@pytest.mark.testnets
@pytest.mark.usefixtures("skip_on_no_env", "set_network_id_env")
def test_neg_query_protocol_state(
self,
skip_on_no_env: None, # noqa: ARG002
set_network_id_env: None, # noqa: ARG002
cluster: clusterlib.ClusterLib,
env_scenario: str,
arg_scenario: str,
Expand Down Expand Up @@ -339,10 +332,9 @@ def test_neg_query_protocol_state(
@PARAM_ARG_SCENARIO
@pytest.mark.smoke
@pytest.mark.testnets
@pytest.mark.usefixtures("skip_on_no_env", "set_network_id_env")
def test_neg_query_stake_distribution(
self,
skip_on_no_env: None, # noqa: ARG002
set_network_id_env: None, # noqa: ARG002
cluster: clusterlib.ClusterLib,
env_scenario: str,
arg_scenario: str,
Expand Down Expand Up @@ -378,10 +370,9 @@ def test_neg_query_stake_distribution(
@PARAM_ARG_SCENARIO
@pytest.mark.smoke
@pytest.mark.testnets
@pytest.mark.usefixtures("skip_on_no_env", "set_network_id_env")
def test_neg_query_protocol_params(
self,
skip_on_no_env: None, # noqa: ARG002
set_network_id_env: None, # noqa: ARG002
cluster: clusterlib.ClusterLib,
env_scenario: str,
arg_scenario: str,
Expand Down Expand Up @@ -417,10 +408,9 @@ def test_neg_query_protocol_params(
@PARAM_ARG_SCENARIO
@pytest.mark.smoke
@pytest.mark.testnets
@pytest.mark.usefixtures("skip_on_no_env", "set_network_id_env")
def test_neg_query_pool_state(
self,
skip_on_no_env: None, # noqa: ARG002
set_network_id_env: None, # noqa: ARG002
cluster: clusterlib.ClusterLib,
env_scenario: str,
arg_scenario: str,
Expand Down Expand Up @@ -456,10 +446,9 @@ def test_neg_query_pool_state(
@PARAM_ARG_SCENARIO
@pytest.mark.smoke
@pytest.mark.testnets
@pytest.mark.usefixtures("skip_on_no_env", "set_network_id_env")
def test_neg_query_stake_addr_info(
self,
skip_on_no_env: None, # noqa: ARG002
set_network_id_env: None, # noqa: ARG002
cluster: clusterlib.ClusterLib,
env_scenario: str,
arg_scenario: str,
Expand Down Expand Up @@ -496,10 +485,9 @@ def test_neg_query_stake_addr_info(
@PARAM_ARG_SCENARIO
@pytest.mark.smoke
@pytest.mark.testnets
@pytest.mark.usefixtures("skip_on_no_env", "set_network_id_env")
def test_neg_build_transfer_funds(
self,
skip_on_no_env: None, # noqa: ARG002
set_network_id_env: None, # noqa: ARG002
cluster: clusterlib.ClusterLib,
payment_addrs: list[clusterlib.AddressRecord],
env_scenario: str,
Expand Down
12 changes: 4 additions & 8 deletions cardano_node_tests/tests/test_metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,10 +103,8 @@ class TestPrometheus:
}

@allure.link(helpers.get_vcs_link())
def test_available_metrics(
self,
wait_epochs, # noqa: ARG002
):
@pytest.mark.usefixtures("wait_epochs")
def test_available_metrics(self):
"""Test that list of available Prometheus metrics equals list of expected metrics.

Test Prometheus metrics endpoint to verify all expected metrics are exposed and
Expand Down Expand Up @@ -138,10 +136,8 @@ class TestEKG:
"""EKG metrics tests."""

@allure.link(helpers.get_vcs_link())
def test_available_metrics(
self,
wait_epochs, # noqa: ARG002
):
@pytest.mark.usefixtures("wait_epochs")
def test_available_metrics(self):
"""Test that available EKG metrics matches the expected schema.

Test EKG (Event-driven Key-value) metrics endpoint to verify metrics conform to
Expand Down
18 changes: 9 additions & 9 deletions cardano_node_tests/tests/test_mir_certs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,9 +114,9 @@ class TestMIRCerts:

@allure.link(helpers.get_vcs_link())
@pytest.mark.dbsync
@pytest.mark.usefixtures("skip_on_hf_shortcut")
def test_transfer_to_treasury(
self,
skip_on_hf_shortcut: None, # noqa: ARG002
cluster_manager: cluster_management.ClusterManager,
cluster_pots: clusterlib.ClusterLib,
pool_users: list[clusterlib.PoolUser],
Expand Down Expand Up @@ -196,9 +196,9 @@ def test_transfer_to_treasury(
@allure.link(helpers.get_vcs_link())
@pytest.mark.dbsync
@common.SKIPIF_BUILD_UNUSABLE
@pytest.mark.usefixtures("skip_on_hf_shortcut")
def test_build_transfer_to_treasury(
self,
skip_on_hf_shortcut: None, # noqa: ARG002
cluster_manager: cluster_management.ClusterManager,
cluster_pots: clusterlib.ClusterLib,
pool_users: list[clusterlib.PoolUser],
Expand Down Expand Up @@ -284,9 +284,9 @@ def test_build_transfer_to_treasury(

@allure.link(helpers.get_vcs_link())
@pytest.mark.dbsync
@pytest.mark.usefixtures("skip_on_hf_shortcut")
def test_transfer_to_reserves(
self,
skip_on_hf_shortcut: None, # noqa: ARG002
cluster_manager: cluster_management.ClusterManager,
cluster_pots: clusterlib.ClusterLib,
pool_users: list[clusterlib.PoolUser],
Expand Down Expand Up @@ -366,9 +366,9 @@ def test_transfer_to_reserves(
@allure.link(helpers.get_vcs_link())
@pytest.mark.dbsync
@common.SKIPIF_BUILD_UNUSABLE
@pytest.mark.usefixtures("skip_on_hf_shortcut")
def test_build_transfer_to_reserves(
self,
skip_on_hf_shortcut: None, # noqa: ARG002
cluster_manager: cluster_management.ClusterManager,
cluster_pots: clusterlib.ClusterLib,
pool_users: list[clusterlib.PoolUser],
Expand Down Expand Up @@ -455,9 +455,9 @@ def test_build_transfer_to_reserves(
@allure.link(helpers.get_vcs_link())
@pytest.mark.dbsync
@pytest.mark.parametrize("fund_src", (RESERVES, TREASURY))
@pytest.mark.usefixtures("skip_on_hf_shortcut")
def test_pay_stake_addr_from(
self,
skip_on_hf_shortcut: None, # noqa: ARG002
cluster_manager: cluster_management.ClusterManager,
cluster_pots: clusterlib.ClusterLib,
registered_users: list[clusterlib.PoolUser],
Expand Down Expand Up @@ -546,9 +546,9 @@ def test_pay_stake_addr_from(
@pytest.mark.dbsync
@common.SKIPIF_BUILD_UNUSABLE
@pytest.mark.parametrize("fund_src", (RESERVES, TREASURY))
@pytest.mark.usefixtures("skip_on_hf_shortcut")
def test_build_pay_stake_addr_from(
self,
skip_on_hf_shortcut: None, # noqa: ARG002
cluster_manager: cluster_management.ClusterManager,
cluster_pots: clusterlib.ClusterLib,
registered_users: list[clusterlib.PoolUser],
Expand Down Expand Up @@ -643,9 +643,9 @@ def test_build_pay_stake_addr_from(

@allure.link(helpers.get_vcs_link())
@pytest.mark.dbsync
@pytest.mark.usefixtures("skip_on_hf_shortcut")
def test_pay_stake_addr_from_both(
self,
skip_on_hf_shortcut: None, # noqa: ARG002
cluster_manager: cluster_management.ClusterManager,
cluster_pots: clusterlib.ClusterLib,
registered_users: list[clusterlib.PoolUser],
Expand Down Expand Up @@ -775,9 +775,9 @@ def test_pay_stake_addr_from_both(

@allure.link(helpers.get_vcs_link())
@pytest.mark.dbsync
@pytest.mark.usefixtures("skip_on_hf_shortcut")
def test_pay_multi_stake_addrs(
self,
skip_on_hf_shortcut: None, # noqa: ARG002
cluster_manager: cluster_management.ClusterManager,
cluster_pots: clusterlib.ClusterLib,
registered_users: list[clusterlib.PoolUser],
Expand Down Expand Up @@ -920,9 +920,9 @@ def test_pay_multi_stake_addrs(
@pytest.mark.dbsync
@pytest.mark.parametrize("addr_history", ("addr_known", "addr_unknown"))
@pytest.mark.parametrize("fund_src", (RESERVES, TREASURY))
@pytest.mark.usefixtures("skip_on_hf_shortcut")
def test_pay_unregistered_stake_addr_from( # noqa: C901
self,
skip_on_hf_shortcut: None, # noqa: ARG002
cluster_manager: cluster_management.ClusterManager,
cluster_pots: clusterlib.ClusterLib,
pool_users: list[clusterlib.PoolUser],
Expand Down
Loading
Loading