fix: stale db-sync table names and dead else - #3604
Merged
Merged
Conversation
Use tp.assert_never for the exhaustiveness check in check_epoch_state instead of an unreachable else branch, so adding a new ActionTypes member fails type checking. Fix the copy-pasted "Committee id mismatch" wording in the constitution assert message. Update the pool_offline_data table name to off_chain_pool_data (renamed in db-sync 13.2) in the SMASH debugging examples.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use tp.assert_never for the exhaustiveness check in check_epoch_state instead of an unreachable else branch, so adding a new ActionTypes member fails type checking. Fix the copy-pasted "Committee id mismatch" wording in the constitution assert message.
Update the pool_offline_data table name to off_chain_pool_data (renamed in db-sync 13.2) in the SMASH debugging examples.